Re: [PATCH 2/4] gprs: Add new external APIs to create, activate and remove a PDP context

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1794 bytes --]

Hi Philippe,

On 05/04/2011 12:26 PM, Philippe Nunes wrote:
> ---
>  include/gprs.h |   16 ++++
>  src/gprs.c     |  234 +++++++++++++++++++++++++++++++++++++++++++++++++++++++-
>  2 files changed, 246 insertions(+), 4 deletions(-)
> 
> diff --git a/include/gprs.h b/include/gprs.h
> index 157a6f9..0bb37f7 100644
> --- a/include/gprs.h
> +++ b/include/gprs.h
> @@ -36,6 +36,10 @@ typedef void (*ofono_gprs_status_cb_t)(const struct ofono_error *error,
>  
>  typedef void (*ofono_gprs_cb_t)(const struct ofono_error *error, void *data);
>  
> +typedef void (*ofono_gprs_add_pdp_context_cb_t)(int error, char *interface,
> +						char *ipv4, char *ipv6,
> +						void *data);
> +
>  struct ofono_gprs_driver {
>  	const char *name;
>  	int (*probe)(struct ofono_gprs *gprs, unsigned int vendor,
> @@ -77,7 +81,19 @@ void ofono_gprs_set_cid_range(struct ofono_gprs *gprs,
>  				unsigned int min, unsigned int max);
>  void ofono_gprs_add_context(struct ofono_gprs *gprs,
>  				struct ofono_gprs_context *gc);
> +unsigned int ofono_gprs_add_pdp_context(struct ofono_gprs *gprs,
> +					const char *type,
> +					const char *protocol,
> +					const char *apn,
> +					const char *username,
> +					const char *password,
> +					const char *host);
> +
> +int ofono_gprs_remove_pdp_context(struct ofono_gprs *gprs, unsigned int id);
>  
> +int ofono_gprs_activate_pdp_context(struct ofono_gprs *gprs, unsigned int id,
> +					ofono_gprs_add_pdp_context_cb_t cb,
> +					void *data);

Why do you want to expose STK activated contexts over D-Bus and try to
deal with the consequences of this decision?  Having oFono handle them
completely internally would simplify the design quite a bit, no?

Regards,
-Denis

>  #ifdef __cplusplus
>  }
>  #endif