From: Valentin Longchamp <valentin.longchamp@keymile.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 6/8] arm/km: rename mgcoge2un to mgcoge3un
Date: Thu, 05 May 2011 08:18:36 +0200 [thread overview]
Message-ID: <4DC2413C.1070705@keymile.com> (raw)
In-Reply-To: <20110504221757.EA153126DAA@gemini.denx.de>
Dear Wolfgang Denk,
Wolfgang Denk wrote:
> Dear Valentin Longchamp,
>
> In message <4DC10FEC.1050200@keymile.com> you wrote:
>> The current differences between our kirkwood boards are not many, but
>> since we have new boards coming where the difference number is going to
>> grow, it is going to be hard to keep many (even 2) boards in one single
>> file. That why we prefer to have the differences (and common source code
>> we have to maintain, I agree as well) in .h source files than in the
>> boards.cfg file.
>
> Oops. Common _source_ code in ".h source files" ?
>
> Please don't. Header files are NOT intended for any real source code
> (with th exception of some usually smallish inline fnctions and such).
>
Well, the _source_ code expression is a language abuse in this case.
There is no real source code in these files, only some defines, and I
have even reduced the number of them in the last iteration of the patch
series.
Best Regards
--
Valentin Longchamp
Embedded Software Engineer
Hardware and Chip Integration
______________________________________
KEYMILE AG
Schwarzenburgstr. 73
CH-3097 Liebefeld
Phone +41 31 377 1318
Fax +41 31 377 1212
valentin.longchamp at keymile.com
www.keymile.com
______________________________________
KEYMILE: A Specialist as a Partner
next prev parent reply other threads:[~2011-05-05 6:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-03 14:13 [U-Boot] [PATCH v2 0/8] keymile arm boards update, part 2 Valentin Longchamp
2011-05-03 14:13 ` [U-Boot] [PATCH v2 1/8] arm/km: introduce and manage bootcount environment variable Valentin Longchamp
2011-05-03 14:13 ` [U-Boot] [PATCH v2 2/8] arm/km: remove last_stage_init and unneeded printouts Valentin Longchamp
2011-05-04 7:30 ` Prafulla Wadaskar
2011-05-04 7:43 ` Valentin Longchamp
2011-05-03 14:13 ` [U-Boot] [PATCH v2 3/8] arm/km: add BootROM config file for memphis SDRAM Valentin Longchamp
2011-05-04 7:30 ` Prafulla Wadaskar
2011-05-04 8:07 ` Valentin Longchamp
2011-05-04 22:22 ` Wolfgang Denk
2011-05-05 6:28 ` Valentin Longchamp
2011-05-03 14:13 ` [U-Boot] [PATCH v2 4/8] arm/km: disable ls (through jffs2 support) Valentin Longchamp
2011-05-04 7:30 ` Prafulla Wadaskar
2011-05-03 14:13 ` [U-Boot] [PATCH v2 5/8] arm/km: add second serial interface for kirkwood Valentin Longchamp
2011-05-03 14:13 ` [U-Boot] [PATCH v2 6/8] arm/km: rename mgcoge2un to mgcoge3un Valentin Longchamp
2011-05-04 7:30 ` Prafulla Wadaskar
2011-05-04 8:35 ` Valentin Longchamp
2011-05-04 22:17 ` Wolfgang Denk
2011-05-05 6:18 ` Valentin Longchamp [this message]
2011-05-03 14:13 ` [U-Boot] [PATCH v2 7/8] arm/km: change default settings for egiga on mgcoge3un Valentin Longchamp
2011-05-04 6:58 ` Prafulla Wadaskar
2011-05-04 8:08 ` Valentin Longchamp
2011-05-04 22:15 ` Wolfgang Denk
2011-05-03 14:13 ` [U-Boot] [PATCH v2 8/8] arm/km: update mgcoge3un board support Valentin Longchamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC2413C.1070705@keymile.com \
--to=valentin.longchamp@keymile.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.