From: Johannes Sixt <j.sixt@viscovery.net>
To: Dima Sharov <git.avalakvista@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] shell: add missing initialization of argv0_path
Date: Thu, 05 May 2011 08:58:07 +0200 [thread overview]
Message-ID: <4DC24A7F.20705@viscovery.net> (raw)
In-Reply-To: <62D8CA91-5C11-458E-AADB-D8EC8EB99F09@gmail.com>
Am 5/5/2011 8:40, schrieb Dima Sharov:
> According to c6dfb39 (remote-curl: add missing initialization of
> argv0_path, 2009-10-13), stand-alone programs (non-builtins)
> must call git_extract_argv0_path(argv[0]) in order to help builds
> that derive the installation prefix at runtime. Without this call,
> the program segfaults (or raises an assertion failure).
Good catch! I checked PROGRAM_OBJS in Makefile, and shell.c was the only
one remaining that did not call this function.
-- Hannes
next prev parent reply other threads:[~2011-05-05 6:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-05 6:40 [PATCH] shell: add missing initialization of argv0_path Dima Sharov
2011-05-05 6:58 ` Johannes Sixt [this message]
2011-05-05 16:32 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2011-05-01 6:06 Dima Sharov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC24A7F.20705@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git.avalakvista@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.