All of lore.kernel.org
 help / color / mirror / Atom feed
From: Holger Brunck <holger.brunck@keymile.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ppc, mgcoge: add DIP switch detection
Date: Thu, 05 May 2011 09:12:42 +0200	[thread overview]
Message-ID: <4DC24DEA.7010201@keymile.com> (raw)
In-Reply-To: <20110504200122.2824B126DAA@gemini.denx.de>

Hi,

On 05/04/2011 10:01 PM, Wolfgang Denk wrote:
> Dear Holger Brunck,
> 
> In message <1295951175-3635-1-git-send-email-holger.brunck@keymile.com> you wrote:
>> From: Andreas Huber <andreas.huber@keymile.com>
>>
>> This reads the DIP switch on mgcoge. The DIP switch is connected to
>> the BFTICU (0x40000089) FPGA. If the DIP switch is set the environment
>> variable 'actual_bank' is set to 0 and starts the SW in bank0.
>>
>> Signed-off-by: Andreas Huber <andreas.huber@keymile.com>
>> Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
>> ---
>>  board/keymile/mgcoge/mgcoge.c |   18 ++++++++++++++++++
>>  include/configs/mgcoge.h      |    5 +++++
>>  2 files changed, 23 insertions(+), 0 deletions(-)
> 
> This patch breaks compiling of the  mgcoge2ne  board:
> 
> Configuring for mgcoge2ne board...
> mgcoge.c: In function 'last_stage_init':
> mgcoge.c:305: error: 'CONFIG_SYS_BFTICU_BASE' undeclared (first use in this function)
> mgcoge.c:305: error: (Each undeclared identifier is reported only once
> mgcoge.c:305: error: for each function it appears in.)
> 

Argh sorry.

> 
> Please fix.
> 

In the already posted patch serie
http://lists.denx.de/pipermail/u-boot/2011-May/091976.html
the problem is fixed, should I repost the patch
powerpc/km82xx: rework DIP switch detection
as a standalone patch and rebase the serie or can you take the whole serie?

Best regards
Holger Brunck

  reply	other threads:[~2011-05-05  7:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-25 10:26 [U-Boot] [PATCH] ppc, mgcoge: add DIP switch detection Holger Brunck
2011-04-11 20:41 ` Wolfgang Denk
2011-05-04 20:01 ` Wolfgang Denk
2011-05-05  7:12   ` Holger Brunck [this message]
2011-05-05  7:29     ` Wolfgang Denk
2011-05-05  7:37       ` Holger Brunck
2011-05-05 18:16         ` Wolfgang Denk
2011-05-06  8:10           ` Holger Brunck
2011-05-06 10:17             ` Wolfgang Denk
2011-05-06 11:26               ` Holger Brunck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DC24DEA.7010201@keymile.com \
    --to=holger.brunck@keymile.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.