From: Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH 00/19] qemu-kvm: Cleanup and switch to upstream - Part I
Date: Thu, 05 May 2011 11:22:16 +0300 [thread overview]
Message-ID: <4DC25E38.1080609@redhat.com> (raw)
In-Reply-To: <cover.1304538230.git.jan.kiszka@web.de>
On 05/04/2011 10:43 PM, Jan Kiszka wrote:
> All required bits for this cleanup of qemu-kvm are now upstream and
> merged back - it's time to start the show. There are now 65 patches in
> my queue, and I'm planning for at least 4 rounds.
>
> This first part primarily aims at using upstream kvm_arch_init. Further
> highlights are:
> - switch to upstream CPU register get/put
> - switch to upstream kvmclock
> - sustainable breakage of IA64
>
> Please review/merge.
>
I didn't do a line-by-line review, just a general look around, and it
all looks good except for the MSR behavioural change.
How did you test it? I suggest testing at least vmport in addition to
an autotest run (if you don't have a setup ready, we can do it, but it
would be really helpful to test pre-merge). I guess we can expect a few
regressions but if we're too careful this mess will continue forever.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-05-05 8:22 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-04 19:43 [PATCH 00/19] qemu-kvm: Cleanup and switch to upstream - Part I Jan Kiszka
2011-05-04 19:43 ` [PATCH 01/19] qemu-kvm: Switch to upstream mp_state functions Jan Kiszka
2011-05-04 19:43 ` [PATCH 02/19] qemu-kvm: x86: Use upstream kvmclock device Jan Kiszka
2011-05-04 19:43 ` [PATCH 03/19] Revert "introduce VMSTATE_U64" Jan Kiszka
2011-05-04 19:43 ` [PATCH 04/19] qemu-kvm: x86: Drop MSR reset Jan Kiszka
2011-05-05 8:08 ` Avi Kivity
2011-05-05 8:11 ` Jan Kiszka
2011-05-05 8:16 ` Avi Kivity
2011-05-05 8:27 ` Jan Kiszka
2011-05-05 8:33 ` Avi Kivity
2011-05-05 8:44 ` Jan Kiszka
2011-05-05 8:53 ` Avi Kivity
2011-05-05 9:32 ` Jan Kiszka
2011-05-05 10:22 ` Avi Kivity
2011-05-05 10:36 ` Jan Kiszka
2011-05-05 11:57 ` Avi Kivity
2011-05-05 11:22 ` Gleb Natapov
2011-05-05 11:58 ` Avi Kivity
2011-05-05 12:23 ` Gleb Natapov
2011-05-05 12:42 ` Jan Kiszka
2011-05-05 13:33 ` Marcelo Tosatti
2011-05-05 18:08 ` Gleb Natapov
2011-05-04 19:43 ` [PATCH 05/19] qemu-kvm: Use upstream VCPU reset services Jan Kiszka
2011-05-04 19:43 ` [PATCH 06/19] qemu-kvm: Use upstream vcpu initialization Jan Kiszka
2011-05-04 19:43 ` [PATCH 07/19] qemu-kvm: Start using qemu-thread services Jan Kiszka
2011-05-04 19:43 ` [PATCH 08/19] qemu-kvm: Use upstream kvm_arch_get/put_registers Jan Kiszka
2011-05-04 19:43 ` [PATCH 09/19] qemu-kvm: Use upstream state synchronization services Jan Kiszka
2011-05-04 19:43 ` [PATCH 10/19] qemu-kvm: Drop remaining libkvm fragments Jan Kiszka
2011-05-04 19:43 ` [PATCH 11/19] qemu-kvm: Drop some more unused code Jan Kiszka
2011-05-04 19:43 ` [PATCH 12/19] qemu-kvm: Drop some obsolete/unused fields from kvm_context Jan Kiszka
2011-05-04 19:43 ` [PATCH 13/19] qemu-kvm: Refactor in-kernel irqchip and pit control Jan Kiszka
2011-05-04 19:43 ` [PATCH 14/19] qemu-kvm: Fold kvm_create into kvm_create_context Jan Kiszka
2011-05-04 19:43 ` [PATCH 15/19] qemu-kvm: Fold kvm_arch_qemu_create_context into kvm_arch_create Jan Kiszka
2011-05-04 19:43 ` [PATCH 16/19] qemu-kvm: Push PIT reinjection control into x86 code Jan Kiszka
2011-05-04 19:43 ` [PATCH 17/19] qemu-kvm: Replace kvm_show_regs/code with cpu_dump_state Jan Kiszka
2011-05-04 19:43 ` [PATCH 18/19] qemu-kvm: Fold kvm_init_coalesced_mmio into kvm_create_context Jan Kiszka
2011-05-04 19:43 ` [PATCH 19/19] qemu-kvm: x86: Use kvm_arch_init Jan Kiszka
2011-05-05 8:22 ` Avi Kivity [this message]
2011-05-05 8:29 ` [PATCH 00/19] qemu-kvm: Cleanup and switch to upstream - Part I Jan Kiszka
2011-05-06 13:51 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC25E38.1080609@redhat.com \
--to=avi@redhat.com \
--cc=jan.kiszka@web.de \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.