From: Jonathan Cameron <jic23@cam.ac.uk>
To: Alexander Stein <alexander.stein@systec-electronic.com>
Cc: "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: Re: [PATCH] ads7846: Add possibility to use external vref on ads7846
Date: Thu, 05 May 2011 11:01:25 +0100 [thread overview]
Message-ID: <4DC27575.3010207@cam.ac.uk> (raw)
In-Reply-To: <201105051144.08104.alexander.stein@systec-electronic.com>
On 05/05/11 10:44, Alexander Stein wrote:
> Am Donnerstag, 5. Mai 2011, 11:08:18 schrieb Jonathan Cameron:
>> On 05/05/11 09:32, Alexander Stein wrote:
>>> Just set vref_mv in your platform config to use external vref. Otherwise
>>> the internal one is used.
>>
>> Would be nicer to see this done with the regulator framework. But then if
>> you have a use case on a board where that isn't available, then fair
>> enough.
>
> Well, for the regulator framework I would redesign the driver a bit. Currently
> the analogue inputs are displayed as mV in sysfs. If the current analogue
> input voltage is shown via the regulator framework the ads7846 driver itself
> can shows the actual ADC values. The latter ones don't need to know the
> reference voltage.
> But I think this is a different problem than choosing the reference voltage
> for an ADC for what this patch is for.
I'm somewhat confused by what you mean here. The regulator framework is all
about power supplies. This device would merely be a consumer that asks for
what (if anything) is being uspplied to the external vref line. Basically
it's a more general alternative to supplying the value via platform data.
next prev parent reply other threads:[~2011-05-05 9:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-05 8:32 [PATCH] ads7846: Add possibility to use external vref on ads7846 Alexander Stein
2011-05-05 9:08 ` Jonathan Cameron
2011-05-05 9:44 ` Alexander Stein
2011-05-05 10:01 ` Jonathan Cameron [this message]
2011-05-05 10:16 ` Alexander Stein
2011-05-05 10:33 ` Jonathan Cameron
2011-05-05 10:42 ` Alexander Stein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC27575.3010207@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=alexander.stein@systec-electronic.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.