All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Sixt <j.sixt@viscovery.net>
To: Kacper Kornet <kornet@camk.edu.pl>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH 1/1] Honor $(prefix) set in config.mak* when defining ETC_GIT* and sysconfdir
Date: Thu, 05 May 2011 16:45:40 +0200	[thread overview]
Message-ID: <4DC2B814.5070507@viscovery.net> (raw)
In-Reply-To: <20110505142910.GA31229@camk.edu.pl>

A:

> 1. ./configure --prefix=dir1  and dir1 != /usr
> 
>     git_etcdir = etc
> 
> 2. ./configure --prefix=/usr
> 
>     git_etcdir = /etc
> 
> 3. ./configure --prefix=dir1 --syscondir=dir2 (here dir2 has to be an
> absolute path)
> 
>     git_etcdir =  dir2

Why do you have the restriction that --sysconfdir must be absolute? Is it
imposed by autotools?

  4. ./configure --sysconfdir=dir2

     git_etcdir =  dir2

B:

> 1. make prefix=dir1 and dir1 != /usr
> 
>     git_etcdir = etc
> 
> 2. make prefix=/usr
> 
>     git_etcdir = /etc
> 
> 3. make prefix=dir1 sysconfdir=dir2 (here dir2 can be an absolute or
> a relative path)
> 
>     git_etcdir = dir2

  4. make sysconfdir=dir2

      git_etcdir = dir2

C:
in config.mak write none, one, or both of

  prefix=dir1
  sysconfdir=dir2

with the same 4 case distinctions and corresponding desired results as in B.

Looks fine and simple to implement, except that I don't see that you have
to introduce git_etcdir; can't you just stick with the name "sysconfdir"?

-- Hannes

  reply	other threads:[~2011-05-05 14:45 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-28  2:29 [PATCH] Respect definition of prefix from autotools in ETC_GITCONFIG and ETC_GITATTRIBUTES Kacper Kornet
2011-04-28 16:54 ` Junio C Hamano
2011-04-28 17:49   ` Kacper Kornet
2011-04-28 19:27   ` [PATCH 1/1] Honor $(prefix) set in config.mak* when defining ETC_GIT* and sysconfdir Kacper Kornet
2011-04-28 20:01     ` [PATCH] Honor sysconfdir when set as an configure option Kacper Kornet
2011-04-28 21:05       ` Junio C Hamano
2011-04-28 21:22         ` Kacper Kornet
2011-05-03  6:42     ` [PATCH 1/1] Honor $(prefix) set in config.mak* when defining ETC_GIT* and sysconfdir Johannes Sixt
2011-05-03 17:32       ` Junio C Hamano
2011-05-04  5:52         ` Johannes Sixt
2011-05-04 13:58           ` Kacper Kornet
2011-05-04 14:39             ` Johannes Sixt
2011-05-04 18:21               ` Junio C Hamano
2011-05-05  2:26                 ` Junio C Hamano
2011-05-05  5:58                   ` Johannes Sixt
2011-05-05 16:17                     ` Junio C Hamano
2011-05-06  7:03                       ` Johannes Sixt
2011-05-05 14:29                   ` Kacper Kornet
2011-05-05 14:45                     ` Johannes Sixt [this message]
2011-05-05 15:00                       ` Kacper Kornet
2011-05-05 15:46                         ` Junio C Hamano
2011-05-09  8:24                           ` Johannes Sixt
2011-05-09 11:56                             ` Kacper Kornet
2011-05-27  8:17                             ` Kacper Kornet
2011-05-05 15:25                       ` Kacper Kornet
2011-05-04 14:29         ` Kacper Kornet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DC2B814.5070507@viscovery.net \
    --to=j.sixt@viscovery.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=kornet@camk.edu.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.