From: Ben Greear <greearb@candelatech.com>
To: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Felix Fietkau <nbd@openwrt.org>
Subject: Bisected: ath9k: fix powersave frame filtering/buffering in AP mode broke STA association.
Date: Thu, 05 May 2011 13:44:50 -0700 [thread overview]
Message-ID: <4DC30C42.6070402@candelatech.com> (raw)
I bisected the problem I was having with ath9k STA configured for WPA
not being able to authenticate. I'm using nohwcrypt=1, which may
be why no one else sees it.
According to bisect, this is the first bad commit:
commit 5519541d5a5f19893546883547e2f0f2e5934df7
Author: Felix Fietkau <nbd@openwrt.org>
Date: Sun Apr 17 23:28:09 2011 +0200
ath9k: fix powersave frame filtering/buffering in AP mode
This patch fixes a long standing issue of pending packets in the queue being
sent (and retransmitted many times) to sleeping stations.
This was made worse by aggregation through driver-internal retransmitting
of A-MDPU subframes.
Previously the hardware tx filter was cleared unconditionally for every
single packet - with this patch it uses the IEEE80211_TX_CTL_CLEAR_PS_FILT
for unaggregated frames.
A sta_notify driver op is added to stop aggregation for stations when they
enter powersave mode. Subframes stay buffered inside the driver, to ensure
that the BlockAck window keeps a sane state.
Since the driver uses software aggregation, the clearing of the tx filter
needs to be handled by the driver instead of mac80211 for aggregated frames.
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
I'll be happy to test patches, it seems very easy to reproduce on
my setup.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next reply other threads:[~2011-05-05 20:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-05 20:44 Ben Greear [this message]
2011-05-05 21:03 ` Bisected: ath9k: fix powersave frame filtering/buffering in AP mode broke STA association Felix Fietkau
2011-05-05 21:15 ` Ben Greear
2011-05-05 21:43 ` Ben Greear
2011-05-05 21:54 ` Felix Fietkau
2011-05-06 0:16 ` Ben Greear
2011-05-06 0:44 ` Felix Fietkau
2011-05-06 16:29 ` Ben Greear
2011-05-06 16:51 ` Felix Fietkau
2011-05-06 16:54 ` Ben Greear
2011-05-06 16:58 ` Ben Greear
2011-05-06 17:03 ` Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC30C42.6070402@candelatech.com \
--to=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.