All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: Unint var with GCC 4.5.2
Date: Thu, 05 May 2011 21:25:34 -0500	[thread overview]
Message-ID: <4DC35C1E.80709@gmail.com> (raw)
In-Reply-To: <A782C372B9527D44AB20BF45FEEBB14F75C5086A2D@irsmsx503.ger.corp.intel.com>

[-- Attachment #1: Type: text/plain, Size: 1225 bytes --]

Hi Bertrand,

> 
> The unint var is ‘unsigned short iidf_id;’
> 
> If the image is in the cache, we will go to the watch directly, and if
> there is no watch, we will add one with an invalid iidf_id.
> 

This is a bug.  We need to add a watch to the proper iidf_id, which we
need to obtain from the EFimg look up table.  In the case of a cached
image, we're not doing that.

> So is it possible to have an image in the cache without watch?

Yes, the cache is persistent (stored in IMSI-keyed filesystem location).
 The logic is supposed to work somewhat like this:

1. Upon sim-atom init, read EFimg and populate its contents in a look up
table.

2a. When an application requests an icon with a particular id, look it
up in cache or read it from the SIM.  Each icon is assigned to a
particular EFiidf_n file.  So record application's interest in that file
by assigning a file watch.

2b. If an EFiidf file is refreshed via STK Refresh, call the file watch
and remove the file watch.  The file watch will be re-added again once
the application requests the icon.

However, we have not seen any SIMs with SIM icons, so this part of the
code has not been stress tested...

Regards,
-Denis

  reply	other threads:[~2011-05-06  2:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-06  9:41 Unint var with GCC 4.5.2 Aygon, Bertrand
2011-05-06  2:25 ` Denis Kenzior [this message]
2011-05-06 14:09   ` Aygon, Bertrand
2011-05-06  2:52     ` Denis Kenzior
2011-05-06 18:59 ` Andrzej Zaborowski
2011-05-09  4:28   ` Denis Kenzior
2011-05-09  9:51   ` Aygon, Bertrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DC35C1E.80709@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.