From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Pekka Enberg <penberg@kernel.org>
Cc: Sasha Levin <levinsasha928@gmail.com>,
mingo@elte.hu, asias.hejun@gmail.com, prasadjoshi124@gmail.com,
kvm@vger.kernel.org
Subject: Re: [PATCH 1/2] kvm tools: Fix IRQ assignments
Date: Fri, 06 May 2011 11:31:05 +0400 [thread overview]
Message-ID: <4DC3A3B9.4020509@gmail.com> (raw)
In-Reply-To: <BANLkTikuo4uAGNP=4WB4D-8WKzxFZdtdOw@mail.gmail.com>
On 05/06/2011 11:29 AM, Pekka Enberg wrote:
> On Fri, May 6, 2011 at 10:26 AM, Sasha Levin <levinsasha928@gmail.com> wrote:
>> virtio-blk needs a block of 4 IRQs (currently - staticly defined).
>> Giving the initial IRQ of 15 causes breakage when adding more
>> than one device.
>>
>> Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
>
> Can we make the allocation dynamic instead? AFAICT, it could be a simple as
>
> int kvm__request_irq(struct kvm *kvm)
> {
> return kvm->next_irq++;
> }
>
> that's done at device init time and then we'd just add "int irq" to
> the individual struct devices.
>
> Pekka
Yes, but start with 0x40 as initial vector for devices please.
--
Thanks,
Cyrill
next prev parent reply other threads:[~2011-05-06 7:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-06 7:26 [PATCH 1/2] kvm tools: Fix IRQ assignments Sasha Levin
2011-05-06 7:26 ` [PATCH 2/2] kvm tools: Simplify search for root device Sasha Levin
2011-05-07 8:41 ` Pekka Enberg
2011-05-07 8:46 ` Sasha Levin
2011-05-07 8:49 ` Prasad Joshi
2011-05-06 7:29 ` [PATCH 1/2] kvm tools: Fix IRQ assignments Pekka Enberg
2011-05-06 7:31 ` Cyrill Gorcunov [this message]
2011-05-06 7:36 ` Sasha Levin
2011-05-06 7:43 ` Pekka Enberg
2011-05-06 8:01 ` Sasha Levin
2011-05-06 8:04 ` Pekka Enberg
2011-05-06 8:08 ` Cyrill Gorcunov
2011-05-06 8:10 ` Pekka Enberg
2011-05-06 8:16 ` Cyrill Gorcunov
2011-05-06 7:47 ` Cyrill Gorcunov
2011-05-06 7:59 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC3A3B9.4020509@gmail.com \
--to=gorcunov@gmail.com \
--cc=asias.hejun@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=mingo@elte.hu \
--cc=penberg@kernel.org \
--cc=prasadjoshi124@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.