From: TB <lkml@techboom.com>
To: "Brandeburg, Jesse" <jesse.brandeburg@intel.com>
Cc: Stephen Hemminger <shemminger@vyatta.com>,
David Miller <davem@davemloft.net>,
Sangtae Ha <sangtae.ha@gmail.com>,
Injong Rhee <injongrhee@gmail.com>,
"Valdis.Kletnieks@vt.edu" <Valdis.Kletnieks@vt.edu>,
"rdunlap@xenotime.net" <rdunlap@xenotime.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tcp_cubic: limit delayed_ack ratio to prevent divide error
Date: Fri, 06 May 2011 12:15:46 -0400 [thread overview]
Message-ID: <4DC41EB2.6070404@techboom.com> (raw)
In-Reply-To: <alpine.WNT.2.00.1105041352020.6048@JBRANDEB-DESK2.amr.corp.intel.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 11-05-04 04:53 PM, Brandeburg, Jesse wrote:
>
>
> On Wed, 4 May 2011, Stephen Hemminger wrote:
>
>> TCP Cubic keeps a metric that estimates the amount of delayed
>> acknowledgements to use in adjusting the window. If an abnormally
>> large number of packets are acknowledged at once, then the update
>> could wrap and reach zero. This kind of ACK could only
>> happen when there was a large window and huge number of
>> ACK's were lost.
>>
>> This patch limits the value of delayed ack ratio. The choice of 32
>> is just a conservative value since normally it should be range of
>> 1 to 4 packets.
>>
>> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
>
> patch seems fine, but please credit the reporter (lkml@techboom.com) with
> reporting the issue with logs, maybe even with Reported-by: and some kind
> of reference to the panic message or the email thread in the text or
> header?
We're currently testing the patch on 6 production servers
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQEcBAEBAgAGBQJNxB6yAAoJENOh8x1aI8Ye4ocH/3+6gjWWppgOwql0J4XGGD5R
wJX+u8A+YK2V+GBvxFgQs/qNa3IB/nnWwELolflO80twq2JrOq1I6g2n1VJhHjX4
b5jyROMe2gPHRKESibi84gNIuoImq4bqM/S1u7xWzcikTh8FxCevYQXTNilIKOOf
siuOIypFY7AyqSPjhq5/+HpTrrOQa097PAcVAr8RBO7niyrxAE75ACTolGAKBfvQ
HlOYKmxBT8SbnZ7YJNINopPdtpqz3iaraKWUoT44Wuv8Q8jt0cqB7YJWl0RG/C3y
ABK50Qihl1p6M+LL9jjR2YwVFkjiLyN3fO8g2pjVfn4wh0afFCyWtitN0OFd/4I=
=Vy5E
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2011-05-06 16:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-04 16:03 Divide error in bictcp_cong_avoid ? TB
2011-05-04 17:49 ` Randy Dunlap
2011-05-04 18:33 ` Stephen Hemminger
2011-05-04 18:35 ` Randy Dunlap
2011-05-04 19:03 ` TB
2011-05-04 18:56 ` David Miller
2011-05-04 19:31 ` Valdis.Kletnieks
2011-05-04 19:37 ` Stephen Hemminger
2011-05-04 19:40 ` David Miller
2011-05-04 20:01 ` Valdis.Kletnieks
2011-05-04 20:04 ` [PATCH] tcp_cubic: limit delayed_ack ratio to prevent divide error Stephen Hemminger
2011-05-04 20:53 ` Brandeburg, Jesse
2011-05-06 16:15 ` TB [this message]
2011-05-06 16:53 ` Stephen Hemminger
2011-05-06 17:39 ` TB
2011-05-11 14:49 ` TB
2011-05-11 15:22 ` Stephen Hemminger
2011-05-11 15:35 ` TB
2011-05-08 22:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC41EB2.6070404@techboom.com \
--to=lkml@techboom.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=davem@davemloft.net \
--cc=injongrhee@gmail.com \
--cc=jesse.brandeburg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=sangtae.ha@gmail.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.