From: David Daney <ddaney@caviumnetworks.com>
To: Michal Marek <mmarek@suse.cz>
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org,
devicetree-discuss@lists.ozlabs.org, grant.likely@secretlab.ca,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v3 1/6] of: Allow scripts/dtc/libfdt to be used from kernel code
Date: Fri, 06 May 2011 10:14:26 -0700 [thread overview]
Message-ID: <4DC42C72.1010306@caviumnetworks.com> (raw)
In-Reply-To: <4DC3D3D5.6060007@suse.cz>
On 05/06/2011 03:56 AM, Michal Marek wrote:
> On 5.5.2011 19:02, David Daney wrote:
>> --- /dev/null
>> +++ b/drivers/of/libfdt/Makefile
>> @@ -0,0 +1,8 @@
>> +ccflags-y := -include linux/libfdt_env.h
>> -I$(src)/../../../scripts/dtc/libfdt
>> +
>> +obj-y = fdt.o fdt_wip.o fdt_ro.o
>> +
>> +
>> +$(obj)/%.o: $(src)/../../../scripts/dtc/libfdt/%.c FORCE
>> + $(call cmd,force_checksrc)
>> + $(call if_changed_rule,cc_o_c)
>
> It's just three source files, so you could use three one-line wrappers
> that #include ../../../scripts/dtc/libfdt/<file>.c instead of copying
> the %.c -> %.o rule here.
>
Good idea, that does seem cleaner.
I will adjust the patch.
David Daney
next prev parent reply other threads:[~2011-05-06 17:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-05 17:02 [RFC PATCH v3 0/6] MIPS: Octeon: Use Device Tree David Daney
2011-05-05 17:02 ` David Daney
2011-05-05 17:02 ` [RFC PATCH v3 1/6] of: Allow scripts/dtc/libfdt to be used from kernel code David Daney
2011-05-05 17:02 ` David Daney
2011-05-06 10:56 ` Michal Marek
2011-05-06 10:56 ` Michal Marek
2011-05-06 17:14 ` David Daney [this message]
2011-05-05 17:02 ` [RFC PATCH v3 2/6] of: Make of_find_node_by_path() traverse /aliases for relative paths David Daney
2011-05-06 10:05 ` Sergei Shtylyov
2011-05-19 18:54 ` Grant Likely
2011-05-06 10:17 ` Sergei Shtylyov
2011-05-06 10:17 ` Sergei Shtylyov
2011-05-05 17:02 ` [RFC PATCH v3 3/6] MIPS: Octeon: Add device tree source files David Daney
2011-05-05 17:02 ` David Daney
2011-05-05 17:02 ` [RFC PATCH v3 4/6] MIPS: Prune some target specific code out of prom.c David Daney
2011-05-05 17:02 ` David Daney
2011-05-05 17:02 ` [RFC PATCH v3 5/6] MIPS: Octeon: Add irq_create_of_mapping() and GPIO interrupts David Daney
2011-05-05 17:02 ` [RFC PATCH v3 6/6] MIPS: Octeon: Initialize and fixup device tree David Daney
2011-05-05 17:02 ` David Daney
2011-05-05 17:40 ` [RFC PATCH v3 0/6] MIPS: Octeon: Use Device Tree Grant Likely
2011-05-05 17:48 ` David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC42C72.1010306@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mmarek@suse.cz \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.