From: Stefan Weil <weil@mail.berlios.de>
To: Pedro Scarapicchia Junior <pedro.scarapiccha@br.flextronics.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>,
"Venkateswararao Jujjuri (JV)" <jvrao@linux.vnet.ibm.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] virtio-9p: Fix a memory leak
Date: Sat, 07 May 2011 10:56:52 +0200 [thread overview]
Message-ID: <4DC50954.4060601@mail.berlios.de> (raw)
In-Reply-To: <BANLkTin3R0oFKn8mB4eXQWgG-sWUQurzmg@mail.gmail.com>
Am 07.05.2011 10:34, schrieb Stefan Hajnoczi:
> On Fri, May 6, 2011 at 8:05 PM, Pedro Scarapicchia Junior
> <pedrinho.rep51@gmail.com> wrote:
>> At v9fs_walk_complete(), the memory allocated at v9fs_walk() is not being
>> released leading system to crash due out of memory.
>>
>> This patch releases structure V9fsWalkState after v9fs_walk is complete.
>>
>> Signed-off-by: Pedro Scarapicchia Junior
>> <pedro.scarapiccha@br.flextronics.com>
>> ---
>> hw/9pfs/virtio-9p.c | 2 ++
>> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> Thanks for this patch. I suggest CCing Venkateswararao Jujjuri (JV)
> <jvrao@linux.vnet.ibm.com>, the virtio-9p maintainer (see MAINTAINERS
> file), on future patches so he can pick them up quickly.
>
> Stefan
Releasing the memory in v9fs_walk() were it was allocated
would be cleaner and easier to review. Is this not possible?
Stefan W.
next prev parent reply other threads:[~2011-05-07 8:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-06 19:05 [Qemu-devel] [PATCH] virtio-9p: Fix a memory leak Pedro Scarapicchia Junior
2011-05-07 8:34 ` Stefan Hajnoczi
2011-05-07 8:56 ` Stefan Weil [this message]
2011-05-07 20:27 ` Pedro Scarapicchia Junior
2011-05-08 17:40 ` Venkateswararao Jujjuri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC50954.4060601@mail.berlios.de \
--to=weil@mail.berlios.de \
--cc=jvrao@linux.vnet.ibm.com \
--cc=pedro.scarapiccha@br.flextronics.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.