All of lore.kernel.org
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] RFC: auto-generate ARM mach-types.h file from ARM machine database
Date: Sat, 07 May 2011 12:58:16 +0200	[thread overview]
Message-ID: <4DC525C8.9070000@aribaud.net> (raw)
In-Reply-To: <20110506101436.111F1D60EB7@gemini.denx.de>

Hi Wolfgang,

Le 06/05/2011 12:14, Wolfgang Denk a ?crit :
> Dear Michael Schwingen,
>
> In message<20110505214836.GA5313@discworld.dascon.de>  you wrote:
>>
>> to conclude the discussion in the thread "Re: [U-Boot] Update and Cut down
>> mach types", I tried a short patch that demonstrates how to automatically
>> generate the mach-types.h file from a database dump (from
>> http://www.arm.linux.org.uk/developer/machines/?action=new).
>>
>> This has multiple advantages:
>>   - pulling in new machine types is easier (drop in a new downloaded database
>>     dump), and produces a much smaller diff.
>>   - adding new machines is decoupled from the time they appear in Linux.
>>   - boards that are not in mainline Linux will not be break due to removal of
>>     their mach types from the Linux headers.
>>
>> The AWK and Makefile fragment script is taken verbatim from Linux 2.6.38.3.
>> I think the AWK script is simple enough that it will not require big
>> maintenance efforts (unless the machine database format changes).
>>
>> The patch is edited down - I removed the diff for the deletion of the old
>> mach-types.h file, and shortened the new mach-types file to a few entries
>> just to show the concept - otherwise, the patch would be much too big for
>> the list.
>>
>> Is this an acceptable solution? Should I go on and produce a full-fledged
>> patch?
>
> I agree with the comments alreay made by Mike Frysinger.
>
> In addition, I would like to point out that I consider it mandatory
> thatthe normal build process does NOT involve any network download.
> Instead, it must be run completely based on files checked into the git
> repository only.
>
> That means, that the "update-mach-types" target Mike mentions is
> something that the ARM maintainer can use to update the in-tree copy
> of the mach-types.h file, which then gets commited into the git
> repository.  Also users can run this if they want to use the latest
> version, but it MUST NOT be used for a regular build.

Agreed on all points.

> Best regards,
>
> Wolfgang Denk

Amicalement,
-- 
Albert.

      reply	other threads:[~2011-05-07 10:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-05 21:48 [U-Boot] RFC: auto-generate ARM mach-types.h file from ARM machine database Michael Schwingen
2011-05-06  5:09 ` Mike Frysinger
2011-05-07 10:57   ` Michael Schwingen
2011-05-09  5:37     ` Wolfgang Denk
2011-05-09  6:32       ` Michael Schwingen
2011-05-09 15:29     ` Mike Frysinger
2011-05-09 15:54       ` Michael Schwingen
2011-05-09 16:16         ` Mike Frysinger
2011-05-10 21:50           ` Albert ARIBAUD
2011-05-06 10:14 ` Wolfgang Denk
2011-05-07 10:58   ` Albert ARIBAUD [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DC525C8.9070000@aribaud.net \
    --to=albert.u.boot@aribaud.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.