From: Sebastian Schuberth <sschuberth@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Boris Faure <billiob@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH 1/2] commit: do not cleanup template
Date: Sun, 08 May 2011 10:47:04 +0200 [thread overview]
Message-ID: <4DC65888.7090309@gmail.com> (raw)
In-Reply-To: <7vwri2uv4m.fsf@alter.siamese.dyndns.org>
On 07.05.2011 22:13, Junio C Hamano wrote:
> These two commits change the longstanding behaviour. It is hard to tell if
> the existing behaviour is something people who use commit log message
> templates have relied on (in which case your patch will be a regression to
> them) or they all shared the sense of annoyance and have been wishing to
> be improved (in which case nobody will be inconvenienced with your patch).
> They need to be explained a bit better why these changes are needed.
I forgot this in my first mail: Being one of the poeple that in general
shares Boris' sense of annoyance, I'm voting in favor of his patch [1/2]
(or mine, if it is any better), but not [2/2].
For any poeple that might be inconvenienced by the patch there is a
trivial one-time fix: Strip whitespaces from their template. Because of
this, I believe it is OK to change the long-standing behavior in this case.
--
Sebastian Schuberth
next prev parent reply other threads:[~2011-05-08 8:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-07 15:53 [PATCH 1/2] commit: do not cleanup template Boris Faure
2011-05-07 15:53 ` [PATCH 2/2] commit: do not add a newline after a template Boris Faure
2011-05-07 20:13 ` [PATCH 1/2] commit: do not cleanup template Junio C Hamano
2011-05-07 21:17 ` Boris 'billiob' Faure
2011-05-07 22:31 ` Junio C Hamano
2011-05-08 8:38 ` Sebastian Schuberth
2011-05-08 8:47 ` Sebastian Schuberth [this message]
2011-05-08 10:31 ` [PATCH/RFC v2] Do not strip empty lines / trailing spaces from a commit message template Boris Faure
2011-05-08 12:28 ` Sebastian Schuberth
2011-05-08 18:14 ` Junio C Hamano
2011-05-08 18:55 ` [PATCH/RFC v3] " Boris Faure
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC65888.7090309@gmail.com \
--to=sschuberth@gmail.com \
--cc=billiob@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.