From: Avi Kivity <avi@redhat.com>
To: Takuya Yoshikawa <takuya.yoshikawa@gmail.com>
Cc: mtosatti@redhat.com, andi@firstfloor.org, kvm@vger.kernel.org,
yoshikawa.takuya@oss.ntt.co.jp
Subject: Re: [PATCH 2/2] KVM: Validate userspace_addr of memslot when registered
Date: Mon, 09 May 2011 11:37:32 +0300 [thread overview]
Message-ID: <4DC7A7CC.6020707@redhat.com> (raw)
In-Reply-To: <20110507163538.aeea223b.takuya.yoshikawa@gmail.com>
On 05/07/2011 10:35 AM, Takuya Yoshikawa wrote:
> From: Takuya Yoshikawa<yoshikawa.takuya@oss.ntt.co.jp>
>
> This way, we can avoid checking the user space address many times when
> we read the guest memory.
>
> Although we can do the same for write if we check which slots are
> writable, we do not care write now: reading the guest memory happens
> more often than writing.
Thanks, applied. I changed VERIFY_READ to VERIFY_WRITE, since the
checks are exactly the same.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
prev parent reply other threads:[~2011-05-09 8:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-07 7:31 [PATCH 1/2] KVM: MMU: Clean up gpte reading with copy_from_user() Takuya Yoshikawa
2011-05-07 7:35 ` [PATCH 2/2] KVM: Validate userspace_addr of memslot when registered Takuya Yoshikawa
2011-05-09 8:37 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC7A7CC.6020707@redhat.com \
--to=avi@redhat.com \
--cc=andi@firstfloor.org \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=takuya.yoshikawa@gmail.com \
--cc=yoshikawa.takuya@oss.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.