From: Vladimir Motyka <vladimir.motyka@gmail.com>
To: cjb@laptop.org
Cc: kernel-janitors@vger.kernel.org, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] drivers/mmc/card/block.c: fix potential null dereference
Date: Mon, 09 May 2011 14:05:31 +0000 [thread overview]
Message-ID: <4DC7F4AB.90607@gmail.com> (raw)
When allocation of idata fails there was a null dereferece.
Signed-off-by: Vladimir Motyka <vladimir.motyka@gmail.com>
---
diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
index 407836d..3dec493 100644
--- a/drivers/mmc/card/block.c
+++ b/drivers/mmc/card/block.c
@@ -266,10 +266,10 @@ static struct mmc_blk_ioc_data
*mmc_blk_ioctl_copy_from_user(
return idata;
copy_err:
- kfree(idata->buf);
+ if(idata)
+ kfree(idata->buf);
kfree(idata);
return ERR_PTR(err);
-
}
static int mmc_blk_ioctl_cmd(struct block_device *bdev,
WARNING: multiple messages have this Message-ID (diff)
From: Vladimir Motyka <vladimir.motyka@gmail.com>
To: cjb@laptop.org
Cc: kernel-janitors@vger.kernel.org, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] drivers/mmc/card/block.c: fix potential null dereference 'idata'
Date: Mon, 09 May 2011 16:05:31 +0200 [thread overview]
Message-ID: <4DC7F4AB.90607@gmail.com> (raw)
When allocation of idata fails there was a null dereferece.
Signed-off-by: Vladimir Motyka <vladimir.motyka@gmail.com>
---
diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
index 407836d..3dec493 100644
--- a/drivers/mmc/card/block.c
+++ b/drivers/mmc/card/block.c
@@ -266,10 +266,10 @@ static struct mmc_blk_ioc_data
*mmc_blk_ioctl_copy_from_user(
return idata;
copy_err:
- kfree(idata->buf);
+ if(idata)
+ kfree(idata->buf);
kfree(idata);
return ERR_PTR(err);
-
}
static int mmc_blk_ioctl_cmd(struct block_device *bdev,
next reply other threads:[~2011-05-09 14:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-09 14:05 Vladimir Motyka [this message]
2011-05-09 14:05 ` [PATCH] drivers/mmc/card/block.c: fix potential null dereference 'idata' Vladimir Motyka
2011-05-09 14:32 ` [PATCH] drivers/mmc/card/block.c: fix potential null dereference Julia Lawall
2011-05-09 14:32 ` [PATCH] drivers/mmc/card/block.c: fix potential null dereference 'idata' Julia Lawall
2011-05-09 15:05 ` [PATCH] drivers/mmc/card/block.c: fix potential null dereference Vladimir Motyka
2011-05-09 15:05 ` [PATCH] drivers/mmc/card/block.c: fix potential null dereference 'idata' Vladimir Motyka
2011-05-09 15:13 ` Andy Shevchenko
2011-05-09 15:13 ` Andy Shevchenko
2011-05-09 15:14 ` [PATCH] drivers/mmc/card/block.c: fix potential null dereference Julia Lawall
2011-05-09 15:14 ` [PATCH] drivers/mmc/card/block.c: fix potential null dereference 'idata' Julia Lawall
2011-05-09 16:08 ` [PATCH] drivers/mmc/card/block.c: fix potential null dereference Vladimir Motyka
2011-05-09 16:08 ` [PATCH] drivers/mmc/card/block.c: fix potential null dereference 'idata' Vladimir Motyka
2011-05-09 16:12 ` [PATCH] drivers/mmc/card/block.c: fix potential null dereference Julia Lawall
2011-05-09 16:12 ` [PATCH] drivers/mmc/card/block.c: fix potential null dereference 'idata' Julia Lawall
2011-05-09 20:37 ` [PATCH] drivers/mmc/card/block.c: fix potential null dereference Vladimir Motyka
2011-05-09 20:37 ` [PATCH] drivers/mmc/card/block.c: fix potential null dereference 'idata' Vladimir Motyka
2011-05-09 20:37 ` [PATCH] drivers/mmc/card/block.c: fix potential null dereference Vladimir Motyka
2011-05-09 20:37 ` [PATCH] drivers/mmc/card/block.c: fix potential null dereference 'idata' Vladimir Motyka
2011-05-11 4:03 ` Chris Ball
2011-05-11 4:03 ` Chris Ball
2011-05-10 7:47 ` Andy Shevchenko
2011-05-10 7:47 ` Andy Shevchenko
2011-05-10 7:57 ` [PATCH] drivers/mmc/card/block.c: fix potential null dereference Julia Lawall
2011-05-10 7:57 ` [PATCH] drivers/mmc/card/block.c: fix potential null dereference 'idata' Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC7F4AB.90607@gmail.com \
--to=vladimir.motyka@gmail.com \
--cc=cjb@laptop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.