From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Pekka Enberg <penberg@kernel.org>
Cc: Sasha Levin <levinsasha928@gmail.com>,
Ingo Molnar <mingo@elte.hu>, Asias He <asias.hejun@gmail.com>,
Prasad Joshi <prasadjoshi124@gmail.com>,
kvm-vger <kvm@vger.kernel.org>
Subject: Re: [PATCH] kvm tools: PCI -- Make PCI device numbers being unique
Date: Tue, 10 May 2011 00:10:06 +0400 [thread overview]
Message-ID: <4DC84A1E.3070600@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1105092251090.7275@tiger>
On 05/09/2011 11:53 PM, Pekka Enberg wrote:
>> From: Cyrill Gorcunov <gorcunov@gmail.com>
>> Subject: [PATCH] kvm tools: PCI -- Make PCI device numbers being unique v2
>>
>> PCI device numbers must be unique on a bus (as a part
>> of Bus/Device/Function tuple).Make it so. Note the patch
>> is rather a fast fix since we need a bit more smart pci device
>> manager (in particular multiple virtio block devices most
>> probably should lay on a separate pci bus).
>>
>> v2: Sasha spotted the nit in virtio_rng__init, ioport
>> function was touched insted of irq__register_device.
>
> Hey, I don't like the new patch subject trend you're trying to start at all. You can make it
>
> kvm tools,pci: Make PCI device numbers unique
>
> but in this particular case "PCI" already appears in the title so
>
> kmv tools: Make PCI device numbers unique
>
> is the right thing to do.
PCI stands for kvm tools subsystem, but if you like more the last -- I'm fine with it.
>
> In addition, the changelog doesn't really tell me much. Does it fix something?
> Why would we need a "smart pci device manager" and why is that relevant for this
> patch? Hmmh?
>
> Pekka
The thing is that at moment the id's passed to MP table is incorrect, they are to be
5 bits long (mp spec). The smart manager we need -- it's because there could be multiple
virtio block device and they _are_ to be separated pci devices, ie with own numbers and
intx# assignents. As result we probably should have such virtio devices to lay on a separate
pci bus, or if the number of pci devices exceed the width of address line then
we should pass them to another pci bus. That is what I had in mind but I'm not sure all this
should come to the changelog.
--
Cyrill
prev parent reply other threads:[~2011-05-09 20:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-08 18:29 [PATCH] kvm tools: PCI -- Make PCI device numbers being unique Cyrill Gorcunov
2011-05-08 18:48 ` Sasha Levin
2011-05-08 18:54 ` Cyrill Gorcunov
2011-05-08 19:03 ` Cyrill Gorcunov
2011-05-09 19:53 ` Pekka Enberg
2011-05-09 20:10 ` Cyrill Gorcunov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC84A1E.3070600@gmail.com \
--to=gorcunov@gmail.com \
--cc=asias.hejun@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=mingo@elte.hu \
--cc=penberg@kernel.org \
--cc=prasadjoshi124@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.