All of lore.kernel.org
 help / color / mirror / Atom feed
From: Saul Wold <saul.wold@intel.com>
To: Tom Rini <tom_rini@mentor.com>
Cc: poky@yoctoproject.org
Subject: Re: [PATCH 1/1] qt4: Enable qt4 opengl for ppc
Date: Mon, 09 May 2011 14:49:50 -0700	[thread overview]
Message-ID: <4DC8617E.3010209@intel.com> (raw)
In-Reply-To: <4DC1AF3E.20602@mentor.com>

On 05/04/2011 12:55 PM, Tom Rini wrote:
> On 05/04/2011 04:00 AM, Xiaofeng Yan wrote:
>> From: Xiaofeng Yan<xiaofeng.yan@windriver.com>
>>
>> Fix [# 1020]
>>
>> Signed-off-by: Xiaofeng Yan<xiaofeng.yan@windriver.com>
>> ---
>>   meta/recipes-qt/qt4/qt4-x11-free.inc |    1 +
>>   1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/meta/recipes-qt/qt4/qt4-x11-free.inc b/meta/recipes-qt/qt4/qt4-x11-free.inc
>> index ba08dc8..a711288 100644
>> --- a/meta/recipes-qt/qt4/qt4-x11-free.inc
>> +++ b/meta/recipes-qt/qt4/qt4-x11-free.inc
>> @@ -13,6 +13,7 @@ QT_GLFLAGS_qemux86 = "-opengl"
>>   QT_GLFLAGS_emenlow = "-opengl"
>>   QT_GLFLAGS_atom-pc = "-opengl"
>>   QT_GLFLAGS_qemuppc = "-opengl"
>> +QT_GLFLAGS_mpc8315e-rdb = "-opengl"
>>   QT_CONFIG_FLAGS += "-no-xinerama -no-xkb ${QT_GLFLAGS}"
>>   QT_BASE_NAME ?= "qt4"
>>   QT_BASE_LIB  ?= "libqt"
>
> Can we use more generic overrides here?  Otherwise we'll just fail on
> the next powerpc board.
>
Xiaofeng,

Now that we have re-factored and these changes will meta-yocto or in BSP 
.bbappend files.  Can you make a more appropriate change that also take 
the above comment into account.

Thanks
	Sau!



  reply	other threads:[~2011-05-09 21:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-04 11:00 [PATCH 0/1] qt4: Fix [# 1020] Xiaofeng Yan
2011-05-04 11:00 ` [PATCH 1/1] qt4: Enable qt4 opengl for ppc Xiaofeng Yan
2011-05-04 19:55   ` Tom Rini
2011-05-09 21:49     ` Saul Wold [this message]
2011-05-05  2:22   ` Saul Wold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DC8617E.3010209@intel.com \
    --to=saul.wold@intel.com \
    --cc=poky@yoctoproject.org \
    --cc=tom_rini@mentor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.