From: frank zago <fzago-klaOcWyJdxkshyMvu7JE4pqQE7yCjDx5@public.gmane.org>
To: "Hefty, Sean" <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] rdma cm typo + bug report
Date: Mon, 09 May 2011 17:53:58 -0500 [thread overview]
Message-ID: <4DC87086.60806@systemfabricworks.com> (raw)
In-Reply-To: <1828884A29C6694DAF28B7E6B8A82373B942-P5GAC/sN6hmkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
On 05/09/2011 05:34 PM, Hefty, Sean wrote:
>> I also think there's a bug with ucma_create_cqs()/ucma_destroy_cqs()
>> because ucma_destroy_cqs unconditionally destroys the CQs, even if they
>> were given by the application. librdmacm should only destroy the CQs it
>> created.
>
> I think we're okay here. ucma_create_cqs() only allocates a CQ if the user specified a CQ of NULL as part of the QP attributes. It stores the allocated CQ in id->send/recv_cq. ucma_destroy_cqs() checks for id->send/recv_cq and destroys them.
Indeed. Sorry.
Frank.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2011-05-09 22:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-09 21:50 [PATCH] rdma cm typo + bug report frank zago
[not found] ` <4DC861A7.5010005-klaOcWyJdxkshyMvu7JE4pqQE7yCjDx5@public.gmane.org>
2011-05-09 22:34 ` Hefty, Sean
[not found] ` <1828884A29C6694DAF28B7E6B8A82373B942-P5GAC/sN6hmkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2011-05-09 22:53 ` frank zago [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC87086.60806@systemfabricworks.com \
--to=fzago-klaocwyjdxkshymvu7je4pqqe7ycjdx5@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.