Re: [PATCH] staging: brcm80211: brcmfmac: Fix memset using sizeof(ptr) not sizeof(*ptr)

["Roland Vossen" <rvossen@broadcom.com>]

Nice catch!

Acked-by: Roland Vossen <rvossen@broadcom.com>

On 05/09/2011 05:51 PM, Joe Perches wrote:
> Found via coccinelle script
>
> @@
> type T;
> T* ptr;
> expression E1;
> @@
>
> * memset(E1, 0, sizeof(ptr));
>
> Signed-off-by: Joe Perches<joe@perches.com>
> ---
>   drivers/staging/brcm80211/brcmfmac/wl_iw.c |    4 +---
>   1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/brcm80211/brcmfmac/wl_iw.c b/drivers/staging/brcm80211/brcmfmac/wl_iw.c
> index a16b46c..4b810ed 100644
> --- a/drivers/staging/brcm80211/brcmfmac/wl_iw.c
> +++ b/drivers/staging/brcm80211/brcmfmac/wl_iw.c
> @@ -498,9 +498,7 @@ wl_iw_get_range(struct net_device *dev,
>   	list = (wl_u32_list_t *) channels;
>
>   	dwrq->length = sizeof(struct iw_range);
> -	memset(range, 0, sizeof(range));
> -
> -	range->min_nwid = range->max_nwid = 0;
> +	memset(range, 0, sizeof(*range));
>
>   	list->count = cpu_to_le32(MAXCHANNEL);
>   	error = dev_wlc_ioctl(dev, WLC_GET_VALID_CHANNELS, channels,
>
>
>