From: "Arend van Spriel" <arend@broadcom.com>
To: "gregkh@suse.de" <gregkh@suse.de>
Cc: "Julian Calaby" <julian.calaby@gmail.com>,
"Henry Ptasinski" <henryp@broadcom.com>,
"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 9/9] staging: brcm80211: move utility functions into new module
Date: Tue, 10 May 2011 12:58:20 +0200 [thread overview]
Message-ID: <4DC91A4C.7020305@broadcom.com> (raw)
In-Reply-To: <BANLkTimvWnhJDSdn+fhGw=WAZDU4RPEKmg@mail.gmail.com>
On 05/10/2011 06:18 AM, Julian Calaby wrote:
> Arend, Henry,
>
> One problem I noticed with your patch:
>
> On Tue, May 10, 2011 at 00:33, Arend van Spriel<arend@broadcom.com> wrote:
>> From: Henry Ptasinski<henryp@broadcom.com>
>>
>> Move utility functions shared by the brcmsmac and brcmfmac drivers into a new
>> module, brcmutil.ko. This eliminates the need to compile and link the shared
>> functions into both drivers. Prefix all exported symbols with "bcm_".
>>
>> Cc: devel@linuxdriverproject.org
>> Cc: linux-wireless@vger.kernel.org
>> Reviewed-by: Brett Rudley<brudley@broadcom.com>
>> Signed-off-by: Arend van Spriel<arend@broadcom.com>
>> ---
>> drivers/staging/brcm80211/Makefile | 1 +
>>
>> diff --git a/drivers/staging/brcm80211/Makefile b/drivers/staging/brcm80211/Makefile
>> index c064cdf..287ad0e 100644
>> --- a/drivers/staging/brcm80211/Makefile
>> +++ b/drivers/staging/brcm80211/Makefile
>> @@ -19,5 +19,6 @@
>> subdir-ccflags-y := -DBCMDMA32
>> subdir-ccflags-$(CONFIG_BRCMDBG) += -DBCMDBG -DBCMDBG_ASSERT
>>
>> +obj-m += util/
>> obj-$(CONFIG_BRCMFMAC) += brcmfmac/
>> obj-$(CONFIG_BRCMSMAC) += brcmsmac/
> You should not use obj-m directly - the way this is set up, if module
> support is disabled, then the driver will fail as the brcmutil module
> will not be built. This might also happen if the drivers are built
> into the kernel ('y' rather than 'm')
>
> You should create a new Kconfig variable (say BRCMWLUTIL) and use some
> Kconfig trickery to ensure that it's built properly for the drivers
> that need it, then replace this line with something like
>
> obj-$(CONFIG_BRCMWLUTIL)
>
> The LIB80211 symbol used by the Intel 2x00 (old non-mac80211) wireless
> drivers uses similar trickery to ensure that everything is built
> properly.
Hi Greg,
We were informed about this potential problem. Should I resend this
patch or fix it with a separate patch?
Gr. AvS
Gr. AvS
--
Almost nobody dances sober, unless they happen to be insane.
-- H.P. Lovecraft --
next prev parent reply other threads:[~2011-05-10 11:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1304951590-2411-1-git-send-email-arend@broadcom.com>
2011-05-09 14:33 ` [PATCH 1/9] staging: brcm80211: move header file Arend van Spriel
2011-05-09 14:33 ` [PATCH 2/9] staging: brcm80211: move files only used by brcmsmac into appropriate dir Arend van Spriel
2011-05-09 14:33 ` [PATCH 3/9] staging: brcm80211: delete unneeded files Arend van Spriel
2011-05-09 14:33 ` [PATCH 4/9] staging: brcm80211: remove unnecessary header file Arend van Spriel
2011-05-09 14:33 ` [PATCH 5/9] staging: brcm80211: remove unneeded include path Arend van Spriel
2011-05-09 14:33 ` [PATCH 6/9] staging: brcm80211: remove unused function Arend van Spriel
2011-05-09 14:33 ` [PATCH 7/9] staging: brcm80211: move another file only used by brcmsmac into appropriate dir Arend van Spriel
2011-05-09 14:33 ` [PATCH 8/9] staging: brcm80211: move functions only used by brcmsmac out of utils Arend van Spriel
2011-05-09 14:33 ` [PATCH 9/9] staging: brcm80211: move utility functions into new module Arend van Spriel
2011-05-10 4:18 ` Julian Calaby
2011-05-10 4:20 ` Julian Calaby
2011-05-10 10:58 ` Arend van Spriel [this message]
2011-05-10 18:04 ` Greg KH
2011-05-10 19:04 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC91A4C.7020305@broadcom.com \
--to=arend@broadcom.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@suse.de \
--cc=henryp@broadcom.com \
--cc=julian.calaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.