All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: Felix Fietkau <nbd@openwrt.org>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: ath5k and ath9k bugs still in 2.6.39-rc7
Date: Tue, 10 May 2011 10:48:53 -0700	[thread overview]
Message-ID: <4DC97A85.40109@candelatech.com> (raw)
In-Reply-To: <4DC97189.1090105@openwrt.org>

On 05/10/2011 10:10 AM, Felix Fietkau wrote:
> On 2011-05-10 6:34 PM, Ben Greear wrote:
>> As far as I can tell, ath5k is critically broken due to un-initilized
>> spinlock (fixed in the patch I posted a few days ago), and ath9k stations
>> won't work due to PS bugs that Felix posted fixes for yesterday.
> Did you test my patch for that? I couldn't reproduce the issue, so I
> couldn't test whether my patch fully fixes it.

Better hold off on that patch..looks like the culprit.  Maybe vif is not NULL but
still bogus?


> (gdb) l *(ath_tx_start+0x640)
0xa123 is in ath_tx_start (/home/greearb/git/linux.wireless-testing/drivers/net/wireless/ath/ath9k/xmit.c:1833).
1828							   bf->bf_state.bfs_paprd);
1829	
1830			if (txctl->paprd)
1831				bf->bf_state.bfs_paprd_timestamp = jiffies;
1832	
1833			if ((vif && vif->type != NL80211_IFTYPE_AP &&
1834			            vif->type != NL80211_IFTYPE_AP_VLAN) ||
1835			    !ieee80211_is_data(hdr->frame_control) ||
1836			    (tx_info->flags & IEEE80211_TX_CTL_CLEAR_PS_FILT))
1837				ath9k_hw_set_clrdmask(sc->sc_ah, bf->bf_desc, true);


> - Felix


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


  parent reply	other threads:[~2011-05-10 17:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-10 16:34 ath5k and ath9k bugs still in 2.6.39-rc7 Ben Greear
2011-05-10 17:10 ` Felix Fietkau
2011-05-10 17:20   ` Ben Greear
2011-05-10 17:48   ` Ben Greear [this message]
2011-05-10 18:35     ` Felix Fietkau
2011-05-10 18:36     ` Ben Greear
2011-05-12  3:17 ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DC97A85.40109@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=nbd@openwrt.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.