From: Steve Lawrence <slawrence@tresys.com>
To: Daniel J Walsh <dwalsh@redhat.com>
Cc: SELinux <selinux@tycho.nsa.gov>
Subject: Re: I believe you will need this patch also to build reference policy.
Date: Wed, 11 May 2011 08:31:03 -0400 [thread overview]
Message-ID: <4DCA8187.2050505@tresys.com> (raw)
In-Reply-To: <4DC003DF.3000909@redhat.com>
On 05/03/2011 09:32 AM, Daniel J Walsh wrote:
> Otherwise you end up with a conflict.
> checkpolicy-filename.patchdiff --git a/checkpolicy/policy_scan.l b/checkpolicy/policy_scan.l
> index 427c189..1331c04 100644
> --- a/checkpolicy/policy_scan.l
> +++ b/checkpolicy/policy_scan.l
> @@ -219,10 +219,11 @@ PERMISSIVE { return(PERMISSIVE); }
> {letter}({alnum}|[_\-])*([\.]?({alnum}|[_\-]))* { return(IDENTIFIER); }
> {digit}+|0x{hexval}+ { return(NUMBER); }
> {alnum}* { return(FILENAME); }
> +\.({alnum}|[_\.\-])* { return(FILENAME); }
> {digit}{1,3}(\.{digit}{1,3}){3} { return(IPV4_ADDR); }
> {hexval}{0,4}":"{hexval}{0,4}":"({hexval}|[:.])* { return(IPV6_ADDR); }
> {digit}+(\.({alnum}|[_.])*)? { return(VERSION_IDENTIFIER); }
> -{alnum}+([_\.]|{alnum})+ { return(FILENAME); }
> +{letter}+([-_\.]|{alnum})+ { return(FILENAME); }
> ([_\.]){alnum}+ { return(FILENAME); }
> #line[ ]1[ ]\"[^\n]*\" { set_source_file(yytext+9); }
> #line[ ]{digit}+ { source_lineno = atoi(yytext+6)-1; }
Can't these be merged? I know I merged something similar earlier, but is
it really necessary to have 3 regexs for filename?
\.?({alnum}|[_\.\-])* { return(FILENAME); }
Or am I missing something?
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
next prev parent reply other threads:[~2011-05-11 12:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-03 13:32 I believe you will need this patch also to build reference policy Daniel J Walsh
2011-05-11 12:31 ` Steve Lawrence [this message]
2011-05-11 21:34 ` Daniel J Walsh
2011-05-12 16:03 ` Steve Lawrence
2011-05-12 16:10 ` Daniel J Walsh
2011-05-13 17:35 ` Steve Lawrence
2011-05-14 1:21 ` Daniel J Walsh
2011-05-17 14:25 ` Steve Lawrence
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DCA8187.2050505@tresys.com \
--to=slawrence@tresys.com \
--cc=dwalsh@redhat.com \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.