All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roger Quadros <roger.quadros@nokia.com>
To: ext Michal Nazarewicz <mina86@mina86.com>
Cc: <gregkh@suse.de>, <stern@rowland.harvard.edu>,
	<sshtylyov@mvista.com>, <linux-kernel@vger.kernel.org>,
	<linux-usb@vger.kernel.org>
Subject: Re: [PATCH v3 1/3] usb: gadget: storage: Add fsg_get_toc helper
Date: Wed, 11 May 2011 15:31:49 +0300	[thread overview]
Message-ID: <4DCA81B5.4040208@nokia.com> (raw)
In-Reply-To: <op.vvbgh8ge3l0zgt@mnazarewicz-glaptop>

On 05/11/2011 03:19 PM, ext Michal Nazarewicz wrote:
>> On 04/05/2011 06:43 PM, ext Michal Nazarewicz wrote:
>>> On Tue, 05 Apr 2011 16:59:27 +0200, Roger Quadros wrote:
>>>> + default:
>>>> + /* Multi-session, PMA, ATIP, CD-TEXT not supported/required */
>>>> + return -EINVAL;
>
>> On 04/05/2011 06:43 PM, ext Michal Nazarewicz wrote:
>>> Can we fall back to the old behaviour here?
>
> On Wed, 11 May 2011 09:49:36 +0200, Roger Quadros <roger.
>> What old behaviour? I didn't understand.
>
> Before we were just ignoring the type of ToC requested, right?
> So can we fail back to the ToC we served then when we hit
> an unsupported TOC? Or does it make no sense at all? I'm not
> saying it does. It probably doesn't. ;)
>

Before we were returning -EINVAL for unsupported request. We do the same now.

-- 
regards,
-roger

  reply	other threads:[~2011-05-11 15:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-05 14:59 [PATCH v3 0/3] Make CD-ROM emulation work with Mac OS-X Roger Quadros
2011-04-05 14:59 ` [PATCH v3 1/3] usb: gadget: storage: Add fsg_get_toc helper Roger Quadros
2011-04-05 15:43   ` Michal Nazarewicz
2011-05-11  7:49     ` Roger Quadros
2011-05-11 12:19       ` Michal Nazarewicz
2011-05-11 12:31         ` Roger Quadros [this message]
2011-05-11 12:59           ` Michal Nazarewicz
2011-04-05 14:59 ` [PATCH v3 2/3] usb: gadget: file_storage: Make CD-ROM emulation work with Mac OS-X Roger Quadros
2011-04-05 15:45   ` Michal Nazarewicz
2011-05-11  7:52     ` Roger Quadros
2011-04-05 14:59 ` [PATCH v3 3/3] usb: gadget: f_mass_storage: " Roger Quadros

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DCA81B5.4040208@nokia.com \
    --to=roger.quadros@nokia.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mina86@mina86.com \
    --cc=sshtylyov@mvista.com \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.