From: Breno Leitao <leitao@linux.vnet.ibm.com>
To: David Miller <davem@davemloft.net>
Cc: Anton Blanchard <anton@samba.org>, netdev@vger.kernel.org
Subject: Re: [PATCH] ehea: Fix memory hotplug oops
Date: Wed, 11 May 2011 09:46:51 -0300 [thread overview]
Message-ID: <4DCA853B.6060904@linux.vnet.ibm.com> (raw)
In-Reply-To: <20110511121710.05ab8c2e@kryten>
On 05/10/2011 11:17 PM, Anton Blanchard wrote:
>
> The ehea driver oopses during memory hotplug if the ports are not
> up. A simple testcase:
>
> # ifconfig ethX down
> # echo offline > /sys/devices/system/memory/memory32/state
>
> Oops: Kernel access of bad area, sig: 11 [#1]
> last sysfs file: /sys/devices/system/memory/memory32/state
> REGS: c000000709393110 TRAP: 0300 Not tainted
(2.6.39-rc2-01385-g7ef73bc-dirty)
> DAR: 0000000000000000, DSISR: 40000000
> ...
> NIP [c000000000067c98] .__wake_up_common+0x48/0xf0
> LR [c00000000006d034] .__wake_up+0x54/0x90
> Call Trace:
> [c00000000006d034] .__wake_up+0x54/0x90
> [d000000006bb6270] .ehea_rereg_mrs+0x140/0x730 [ehea]
> [d000000006bb69c4] .ehea_mem_notifier+0x164/0x170 [ehea]
> [c0000000006fc8a8] .notifier_call_chain+0x78/0xf0
> [c0000000000b3d70] .__blocking_notifier_call_chain+0x70/0xb0
> [c000000000458d78] .memory_notify+0x28/0x40
> [c0000000001871d8] .remove_memory+0x208/0x6d0
> [c000000000458264] .memory_section_action+0x94/0x140
> [c0000000004583ec] .memory_block_change_state+0xdc/0x1d0
> [c0000000004585cc] .store_mem_state+0xec/0x160
> [c00000000044768c] .sysdev_store+0x3c/0x50
> [c00000000020b48c] .sysfs_write_file+0xec/0x1f0
> [c00000000018f86c] .vfs_write+0xec/0x1e0
> [c00000000018fa88] .SyS_write+0x58/0xd0
>
> To fix this, initialise the waitqueues during port probe instead
> of port open.
>
> Signed-off-by: Anton Blanchard <anton@samba.org>
Acked-by: Breno Leitao <leitao@linux.vnet.ibm.com>
next prev parent reply other threads:[~2011-05-11 16:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-11 2:17 [PATCH] ehea: Fix memory hotplug oops Anton Blanchard
2011-05-11 12:46 ` Breno Leitao [this message]
2011-05-12 4:38 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DCA853B.6060904@linux.vnet.ibm.com \
--to=leitao@linux.vnet.ibm.com \
--cc=anton@samba.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.