From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boaz Harrosh Subject: Re: [PATCH 15/18] exofs: remove unnecessary dentry_unhash on rmdir/rename_dir Date: Wed, 11 May 2011 15:53:30 +0300 Message-ID: <4DCA86CA.30900@panasas.com> References: <1305002616-16782-1-git-send-email-sage@newdream.net> <1305002616-16782-16-git-send-email-sage@newdream.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: viro@ZenIV.linux.org.uk, hch@lst.de, linux-fsdevel@vger.kernel.org, Benny Halevy , osd-dev@open-osd.org To: Sage Weil Return-path: Received: from daytona.panasas.com ([67.152.220.89]:28257 "EHLO daytona.panasas.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755004Ab1EKPrc (ORCPT ); Wed, 11 May 2011 11:47:32 -0400 In-Reply-To: <1305002616-16782-16-git-send-email-sage@newdream.net> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 05/10/2011 07:43 AM, Sage Weil wrote: > Exofs has no problems with lingering references to unlinked directory > inodes. > > CC: Boaz Harrosh > CC: Benny Halevy > CC: osd-dev@open-osd.org > Signed-off-by: Sage Weil Acked-by: Boaz Harrosh Sounds good, Thanks > --- > fs/exofs/namei.c | 5 ----- > 1 files changed, 0 insertions(+), 5 deletions(-) > > diff --git a/fs/exofs/namei.c b/fs/exofs/namei.c > index de252e5..4d70db1 100644 > --- a/fs/exofs/namei.c > +++ b/fs/exofs/namei.c > @@ -227,8 +227,6 @@ static int exofs_rmdir(struct inode *dir, struct dentry *dentry) > struct inode *inode = dentry->d_inode; > int err = -ENOTEMPTY; > > - dentry_unhash(dentry); > - > if (exofs_empty_dir(inode)) { > err = exofs_unlink(dir, dentry); > if (!err) { > @@ -251,9 +249,6 @@ static int exofs_rename(struct inode *old_dir, struct dentry *old_dentry, > struct exofs_dir_entry *old_de; > int err = -ENOENT; > > - if (new_inode && S_ISDIR(new_inode->i_mode)) > - dentry_unhash(new_dentry); > - > old_de = exofs_find_entry(old_dir, old_dentry, &old_page); > if (!old_de) > goto out;