All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] fix ppp protocol-reject constructing error
Date: Wed, 11 May 2011 13:34:27 -0500	[thread overview]
Message-ID: <4DCAD6B3.5090701@gmail.com> (raw)
In-Reply-To: <1305101719-2913-1-git-send-email-caiwen.zhang@windriver.com>

[-- Attachment #1: Type: text/plain, Size: 787 bytes --]

Hi Caiwen,

On 05/11/2011 03:15 AM, Caiwen Zhang wrote:
> In PPP Protocol-Reject package the 'rejected data field' should be a copy
> of the rejected package, the copy starts from the data field. besides, 
> Protocol-Reject package include a 'rejected protocol field', it is the
> same as the protocol field of the rejected package.
> 
> Protocol-Reject package structure is:
> 
> 	| PPP_header | rejected protocol | rejected data
> 
> The rejected package structure is:
> 	| Addr | Control | protocol | data
> 	
> So the Protocol-Reject package data field is copied from the 3rd byte of
> the rejected package.
> 
> ---
>  gatchat/ppp_cp.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 

Patch has been applied, thanks.

Regards,
-Denis

      reply	other threads:[~2011-05-11 18:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-11  8:15 [PATCH] fix ppp protocol-reject constructing error Caiwen Zhang
2011-05-11 18:34 ` Denis Kenzior [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DCAD6B3.5090701@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.