From: Sergei Shtylyov <sshtylyov@mvista.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] post: add gpio hotkey support
Date: Thu, 12 May 2011 16:47:56 +0400 [thread overview]
Message-ID: <4DCBD6FC.9020101@mvista.com> (raw)
In-Reply-To: <201105111054.50052.vapier@gentoo.org>
Hello.
On 11-05-2011 18:54, Mike Frysinger wrote:
>>> @@ -68,6 +72,23 @@ int post_init_f (void)
>>> int __post_hotkeys_pressed(void)
>>> {
>>> +#ifdef CONFIG_SYS_POST_HOTKEYS_GPIO
>>> + int ret;
>>> + unsigned gpio = CONFIG_SYS_POST_HOTKEYS_GPIO;
>>> +
>>> + ret = gpio_request(gpio, "hotkeys");
>>> + if (ret) {
>>> + printf("POST: gpio hotkey request failed\n");
>>> + return 0;
>>> + }
>>> +
>>> + gpio_direction_input(gpio);
>>> + ret = gpio_get_value(gpio);
>>> + gpio_free(gpio);
>>> +
>>> + return ret;
>>> +#endif
>> You surely meant #else here?
>>> +
>>> return 0; /* No hotkeys supported */
> not really what i was going for. it's fine either way though.
I don't think 2 returns in a row is fine...
> -mike
WBR, Sergei
next prev parent reply other threads:[~2011-05-12 12:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-10 17:01 [U-Boot] [PATCH] post: add gpio hotkey support Mike Frysinger
2011-05-11 11:42 ` Sergei Shtylyov
2011-05-11 14:54 ` Mike Frysinger
2011-05-12 12:47 ` Sergei Shtylyov [this message]
2011-05-12 15:08 ` Mike Frysinger
2011-07-26 14:47 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DCBD6FC.9020101@mvista.com \
--to=sshtylyov@mvista.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.