From: Kazuya Mio <k-mio@sx.jp.nec.com>
To: Lukas Czerner <lczerner@redhat.com>
Cc: linux-ext4@vger.kernel.org, tytso@mit.edu
Subject: Re: [PATCH] ext4: invalidate gap cache when writing extents last block
Date: Fri, 13 May 2011 17:55:36 +0900 [thread overview]
Message-ID: <4DCCF208.3040704@sx.jp.nec.com> (raw)
In-Reply-To: <1305268616-5167-1-git-send-email-lczerner@redhat.com>
2011/05/13 15:36, Lukas Czerner wrote:
> That is because due to defensive programming we planted a lot of
> BUG_ON's to prevent the length of the gap cache to be zero, but in this
> case it actually will be zero, because there will be no gap at the end
> of the file.
Um, I think there is a block (blocksize -1 byte) in gap.
And this gap should be used for the next block searching.
According to ext4_ext_in_cache(), len=0 means the special case
which we have no cache extent, so len=0 should be disallowed.
Moreover, if we create the file which has 2^32-1 offset,
we can't get extent which starts from this offset with FIEMAP ioctl.
That's why I think the maximum file size should be 2^32-1 * blocksize.
Regards,
Kazuya Mio
next prev parent reply other threads:[~2011-05-13 8:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-11 8:08 [PATCH] ext4: Fix max file size of extent format file Kazuya Mio
2011-05-13 6:34 ` Lukas Czerner
2011-05-13 6:36 ` [PATCH] ext4: invalidate gap cache when writing extents last block Lukas Czerner
2011-05-13 8:55 ` Kazuya Mio [this message]
2011-05-24 8:33 ` Kazuya Mio
2011-05-24 8:57 ` Lukas Czerner
2011-05-25 8:59 ` Kazuya Mio
2011-06-03 17:35 ` [PATCH] ext4: Fix max file size of extent format file Andreas Dilger
2011-06-03 18:08 ` Lukas Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DCCF208.3040704@sx.jp.nec.com \
--to=k-mio@sx.jp.nec.com \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.