From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefano Babic <sbabic@denx.de>
Date: Fri, 13 May 2011 11:01:36 +0200
Subject: [U-Boot] [PATCH] MX53: Add initial support for MX53SMD board.
In-Reply-To: <1305226572-25710-1-git-send-email-fabio.estevam@freescale.com>
References: <1305226572-25710-1-git-send-email-fabio.estevam@freescale.com>
Message-ID: <4DCCF370.4010308@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 05/12/2011 08:56 PM, Fabio Estevam wrote:
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---

Hi Fabio,

only a few comments.

> diff --git a/board/freescale/mx53smd/imximage.cfg b/board/freescale/mx53smd/imximage.cfg
> new file mode 100644
> index 0000000..921f2d9
> --- /dev/null
> +++ b/board/freescale/mx53smd/imximage.cfg
> @@ -0,0 +1,96 @@
> +#
> +# (C Copyright 2009

Can you add the missing ")" ? I know it was my mistake, but we are
spreading this on more files ;-)

> +int board_mmc_getcd(u8 *cd, struct mmc *mmc)
> +{
> +	*cd = mxc_gpio_get(77); /*GPIO3_13*/
> +
> +	return 0;
> +}
> +
> +int board_mmc_init(bd_t *bis)
> +{
> +	u32 index;
> +	s32 status = 0;
> +
> +	for (index = 0; index < CONFIG_SYS_FSL_ESDHC_NUM; index++) {

You have a loop, but you set CONFIG_SYS_FSL_ESDHC_NUM to 1. How many SD
slots has this board ? If you have only one, do we need the loop ? I
know, this is a personal taste, I am not against if you think the code
is clear enough. As I do not know your board, I want mainly know if this
board supports more as one slot, maybe in future.

> +int board_late_init(void)
> +{
> +	return 0;
> +}

If you do not need this function, simply drop BOARD_LATE_INIT from the
config file and remove this function.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================