From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757963Ab1EMKOO (ORCPT ); Fri, 13 May 2011 06:14:14 -0400 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:34033 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756161Ab1EMKON (ORCPT ); Fri, 13 May 2011 06:14:13 -0400 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 Message-ID: <4DCD04D5.80500@jp.fujitsu.com> Date: Fri, 13 May 2011 19:15:49 +0900 From: KOSAKI Motohiro User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv:1.9.2.17) Gecko/20110414 Lightning/1.0b2 Thunderbird/3.1.10 MIME-Version: 1.0 To: David Rientjes CC: CAI Qian , avagin@gmail.com, Andrey Vagin , Andrew Morton , Mel Gorman , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Minchan Kim , Hugh Dickins , Oleg Nesterov Subject: Re: [PATCH 2/4] oom: kill younger process first References: <20110509182110.167F.A69D9226@jp.fujitsu.com> <20110510171335.16A7.A69D9226@jp.fujitsu.com> <20110510171641.16AF.A69D9226@jp.fujitsu.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (2011/05/11 8:31), David Rientjes wrote: > On Tue, 10 May 2011, KOSAKI Motohiro wrote: > >> This patch introduces do_each_thread_reverse() and >> select_bad_process() uses it. The benefits are two, >> 1) oom-killer can kill younger process than older if >> they have a same oom score. Usually younger process >> is less important. 2) younger task often have PF_EXITING >> because shell script makes a lot of short lived processes. >> Reverse order search can detect it faster. >> > > I like this change, thanks! I'm suprised we haven't needed a > do_each_thread_reverse() in the past somewhere else in the kernel. > > Could you update the comment about do_each_thread() not being break-safe > in the second version, though? ok. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail202.messagelabs.com (mail202.messagelabs.com [216.82.254.227]) by kanga.kvack.org (Postfix) with ESMTP id 260A96B0025 for ; Fri, 13 May 2011 06:14:16 -0400 (EDT) Received: from m3.gw.fujitsu.co.jp (unknown [10.0.50.73]) by fgwmail5.fujitsu.co.jp (Postfix) with ESMTP id 8CFBD3EE0BD for ; Fri, 13 May 2011 19:14:12 +0900 (JST) Received: from smail (m3 [127.0.0.1]) by outgoing.m3.gw.fujitsu.co.jp (Postfix) with ESMTP id 72E1045DE93 for ; Fri, 13 May 2011 19:14:12 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (s3.gw.fujitsu.co.jp [10.0.50.93]) by m3.gw.fujitsu.co.jp (Postfix) with ESMTP id 5B0B345DE91 for ; Fri, 13 May 2011 19:14:12 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id 4E6DAE08002 for ; Fri, 13 May 2011 19:14:12 +0900 (JST) Received: from m105.s.css.fujitsu.com (m105.s.css.fujitsu.com [10.240.81.145]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id 1A3AF1DB8037 for ; Fri, 13 May 2011 19:14:12 +0900 (JST) Message-ID: <4DCD04D5.80500@jp.fujitsu.com> Date: Fri, 13 May 2011 19:15:49 +0900 From: KOSAKI Motohiro MIME-Version: 1.0 Subject: Re: [PATCH 2/4] oom: kill younger process first References: <20110509182110.167F.A69D9226@jp.fujitsu.com> <20110510171335.16A7.A69D9226@jp.fujitsu.com> <20110510171641.16AF.A69D9226@jp.fujitsu.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: David Rientjes Cc: CAI Qian , avagin@gmail.com, Andrey Vagin , Andrew Morton , Mel Gorman , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Minchan Kim , Hugh Dickins , Oleg Nesterov (2011/05/11 8:31), David Rientjes wrote: > On Tue, 10 May 2011, KOSAKI Motohiro wrote: > >> This patch introduces do_each_thread_reverse() and >> select_bad_process() uses it. The benefits are two, >> 1) oom-killer can kill younger process than older if >> they have a same oom score. Usually younger process >> is less important. 2) younger task often have PF_EXITING >> because shell script makes a lot of short lived processes. >> Reverse order search can detect it faster. >> > > I like this change, thanks! I'm suprised we haven't needed a > do_each_thread_reverse() in the past somewhere else in the kernel. > > Could you update the comment about do_each_thread() not being break-safe > in the second version, though? ok. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org