From mboxrd@z Thu Jan 1 00:00:00 1970 From: stefano babic Date: Sun, 15 May 2011 11:35:53 +0200 Subject: [U-Boot] [PATCH 2/2] MX53: Add initial support for MX53ARD board In-Reply-To: <1305379673-25948-2-git-send-email-fabio.estevam@freescale.com> References: <1305379673-25948-1-git-send-email-fabio.estevam@freescale.com> <1305379673-25948-2-git-send-email-fabio.estevam@freescale.com> Message-ID: <4DCF9E79.9020703@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Am 14/05/2011 15:27, schrieb Fabio Estevam: Hi Fabio, > --- > Stefano, this patch applies on your u-boot-imx tree with my previous MX53SMD patch applied. Ok > + > +void weim_smc911x_iomux() > +{ > + unsigned int reg; > + > + /* ETHERNET_INT_B as GPIO2_31 */ > + mxc_request_iomux(MX53_PIN_EIM_EB3, > + IOMUX_CONFIG_ALT1); > + reg = readl(GPIO2_BASE_ADDR + 0x4); > + reg &= ~(0x80000000); > + writel(reg, GPIO2_BASE_ADDR + 0x4); You have already included the mxc_gpio. You must use the mxc_gpio_* function to access gpios. > + > +void weim_cs1_settings() > +{ > + unsigned int reg; > + > + writel(0x20001, (WEIM_BASE_ADDR + 0x18)); > + writel(0x0, (WEIM_BASE_ADDR + 0x1C)); > + writel(0x16000202, (WEIM_BASE_ADDR + 0x20)); > + writel(0x00000002, (WEIM_BASE_ADDR + 0x24)); > + writel(0x16002082, (WEIM_BASE_ADDR + 0x28)); > + writel(0x00000000, (WEIM_BASE_ADDR + 0x2C)); > + writel(0x00000000, (WEIM_BASE_ADDR + 0x90)); Access to register with address + offset is not allowed. The right structures are already defined in imx-regs.h. Use "struct weim" to access to the weim registers. > + /* specify 64 MB on CS1 and CS0 */ > + reg = readl(IOMUXC_BASE_ADDR + 0x4); > + reg &= ~0x3F; > + reg |= 0x1B; > + writel(reg, (IOMUXC_BASE_ADDR + 0x4)); Even here you must use structures to access registers. > + > +#define CONFIG_OF_LIBFDT > +#define CONFIG_SYS_BOOTMAPSZ 0x800000 CONFIG_SYS_BOOTMAPSZ is condidered obsolete and removed in a recent commit. Best regards, Stefano -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================