[PATCH] ALSA: HDA: Use one dmic only for Dell Studio 1558

[PATCH] ALSA: HDA: Use one dmic only for Dell Studio 1558

[David Henningsson]

[-- Attachment #1: Type: text/plain, Size: 281 bytes --]

There are no signs of a dmic at node 0x0b, so the user is left with
an additional internal mic which does not exist. This commit removes
that non-existing mic.

Codec info at http://bugs.launchpad.net/bugs/731706.

-- 
David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic

[-- Attachment #2: 0001-ALSA-HDA-Use-one-dmic-only-for-Dell-Studio-1558.patch --]
[-- Type: text/x-patch, Size: 1223 bytes --]

>From 2eea04a7904dcc6071c96f70ca9991cd32bbd34b Mon Sep 17 00:00:00 2001
From: David Henningsson <david.henningsson@canonical.com>
Date: Mon, 16 May 2011 12:09:29 +0200
Subject: [PATCH] ALSA: HDA: Use one dmic only for Dell Studio 1558

There are no signs of a dmic at node 0x0b, so the user is left with
an additional internal mic which does not exist. This commit removes
that non-existing mic.

Cc: stable@kernel.org (2.6.32+)
BugLink: http://bugs.launchpad.net/bugs/731706
Reported-by: James Page <james.page@canonical.com>
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
---
 sound/pci/hda/patch_sigmatel.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c
index a2884bb..38f4317 100644
--- a/sound/pci/hda/patch_sigmatel.c
+++ b/sound/pci/hda/patch_sigmatel.c
@@ -1604,7 +1604,7 @@ static const struct snd_pci_quirk stac92hd73xx_cfg_tbl[] = {
 	SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x02fe,
 				"Dell Studio XPS 1645", STAC_DELL_M6_BOTH),
 	SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x0413,
-				"Dell Studio 1558", STAC_DELL_M6_BOTH),
+				"Dell Studio 1558", STAC_DELL_M6_DMIC),
 	{} /* terminator */
 };
 
-- 
1.7.4.1


[-- Attachment #3: Type: text/plain, Size: 0 bytes --]

Re: [PATCH] ALSA: HDA: Use one dmic only for Dell Studio 1558

[Takashi Iwai]

At Mon, 16 May 2011 12:18:23 +0200,
David Henningsson wrote:
> 
> There are no signs of a dmic at node 0x0b, so the user is left with
> an additional internal mic which does not exist. This commit removes
> that non-existing mic.
> 
> Codec info at http://bugs.launchpad.net/bugs/731706.

Applied now.  Thanks.


Takashi

> 
> -- 
> David Henningsson, Canonical Ltd.
> http://launchpad.net/~diwic
> [2 0001-ALSA-HDA-Use-one-dmic-only-for-Dell-Studio-1558.patch <text/x-patch (7bit)>]
> >From 2eea04a7904dcc6071c96f70ca9991cd32bbd34b Mon Sep 17 00:00:00 2001
> From: David Henningsson <david.henningsson@canonical.com>
> Date: Mon, 16 May 2011 12:09:29 +0200
> Subject: [PATCH] ALSA: HDA: Use one dmic only for Dell Studio 1558
> 
> There are no signs of a dmic at node 0x0b, so the user is left with
> an additional internal mic which does not exist. This commit removes
> that non-existing mic.
> 
> Cc: stable@kernel.org (2.6.32+)
> BugLink: http://bugs.launchpad.net/bugs/731706
> Reported-by: James Page <james.page@canonical.com>
> Signed-off-by: David Henningsson <david.henningsson@canonical.com>
> ---
>  sound/pci/hda/patch_sigmatel.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c
> index a2884bb..38f4317 100644
> --- a/sound/pci/hda/patch_sigmatel.c
> +++ b/sound/pci/hda/patch_sigmatel.c
> @@ -1604,7 +1604,7 @@ static const struct snd_pci_quirk stac92hd73xx_cfg_tbl[] = {
>  	SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x02fe,
>  				"Dell Studio XPS 1645", STAC_DELL_M6_BOTH),
>  	SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x0413,
> -				"Dell Studio 1558", STAC_DELL_M6_BOTH),
> +				"Dell Studio 1558", STAC_DELL_M6_DMIC),
>  	{} /* terminator */
>  };
>  
> -- 
> 1.7.4.1
>