From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 0/30] nVMX: Nested VMX, v9 Date: Mon, 16 May 2011 13:20:10 +0300 Message-ID: <4DD0FA5A.8040700@redhat.com> References: <1304842511-nyh@il.ibm.com> <4DC7CD81.2070305@redhat.com> <20110511082027.GG19019@redhat.com> <20110512154228.GA7943@fermat.math.technion.ac.il> <20110512155727.GA20193@redhat.com> <20110512163115.GA13138@fermat.math.technion.ac.il> <20110512165157.GC20193@redhat.com> <4DCC123B.3080006@redhat.com> <20110515231140.GA17294@fermat.math.technion.ac.il> <4DD0F35A.2010901@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Gleb Natapov , kvm@vger.kernel.org, abelg@il.ibm.com To: "Nadav Har'El" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:1026 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753893Ab1EPKUX (ORCPT ); Mon, 16 May 2011 06:20:23 -0400 In-Reply-To: <4DD0F35A.2010901@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 05/16/2011 12:50 PM, Avi Kivity wrote: >> Or do you consider this not enough, and rather that it is necessary that >> nested VMX should use exactly the same logic as nested SVM does - >> namely, >> use tricks like SVM's "exit_required" instead of our different tricks? > > > I think svm is rather simple here using svm_complete_interrupts() to > decode exit_int_info into the arch independent structures. I don't > think ->exit_required is a hack - it could probably be improved but I > think it does the right thing essentially. For example > svm_nmi_allowed() will return true if in guest mode and NMI > interception is enabled. > It would be better if it just returned true and let svm_inject_nmi() do the vmexit. -- error compiling committee.c: too many arguments to function