From: Liam Girdwood <lrg@ti.com>
To: Stephen Warren <swarren@nvidia.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCHv2] ASoC: Fix wrong data type access in a few codec drivers
Date: Mon, 16 May 2011 14:43:20 +0100 [thread overview]
Message-ID: <4DD129F8.2070306@ti.com> (raw)
In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF04986AA5AC@HQMAIL01.nvidia.com>
On 13/05/11 17:40, Stephen Warren wrote:
> Jarkko Nikula wrote at Friday, May 13, 2011 10:17 AM:
>> Commit fafd217 ("ASoC: Store a list of widgets in a DAPM mux/mixer
>> kcontrol")
>> changed the control private data type that is passed to snd_soc_cnew when
>> creating dapm mixer and mux controls. Commit did not update a few codec
>> drivers that are using their own put callbacks and thus are accessing a
>> wrong data type.
>>
>> Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
>> Tested-by: Stephen Warren <swarren@nvidia.com>
>> ---
>> v2:
>> - wm8994 and wm8995 needs to be changed too. Thanks to
>> Stephen Warren <swarren@nvidia.com> for noticing.
>> - "Otherwise, on Tegra+WM8903, I repro'd the bug, and tested the fix, so:
>> Tested-by: Stephen Warren <swarren@nvidia.com>"
>
> This version looks good to me. I guess that means:
>
> Acked-by: Stephen Warren <swarren@nvidia.com>
>
> ... although I figure my Tested-by is probably enough.
>
> Thanks for fixing my bugs!
>
Acked-by: Liam Girdwood <lrg@ti.com>
next prev parent reply other threads:[~2011-05-16 13:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-13 16:16 [PATCHv2] ASoC: Fix wrong data type access in a few codec drivers Jarkko Nikula
2011-05-13 16:40 ` Stephen Warren
2011-05-16 13:43 ` Liam Girdwood [this message]
2011-05-16 16:07 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DD129F8.2070306@ti.com \
--to=lrg@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.