Re: wpa-supplicant-0.7.inc patch

[Andreas Oberritter <obi@opendreambox.org>]

On 05/16/2011 04:20 PM, Andreas Oberritter wrote:
> On 05/16/2011 04:02 PM, Martin Bures wrote:
>> diff --git a/recipes/wpa-supplicant/wpa-supplicant-0.7.inc
>> b/recipes/wpa-supplicant/wpa-supplicant-0.7.inc
>> index 7649038..abf01c2 100644
>> --- a/recipes/wpa-supplicant/wpa-supplicant-0.7.inc
>> +++ b/recipes/wpa-supplicant/wpa-supplicant-0.7.inc
>> @@ -63,6 +63,7 @@ do_install () {
>>      cd ${D}${sysconfdir}/network/ && \
>>      ln -sf ../if-pre-up.d/wpa-supplicant if-post-down.d/wpa-supplicant
>>
>> +    cd ${S}
> 
> Sorry for not having replied earlier, but I think the more obvious fix
> is to not use "cd" at all. How about this?
> 
> ln -s ../if-pre-up.d/wpa-supplicant
> ${D}${sysconfdir}/network/if-post-down.d/wpa-supplicant
> 
> (Using ln -f just hides possible errors in this case.)

Btw, I think your patch is for an outdated version. The problem was
solved in master by this commit:

commit aa35ba5cf7e1bf30fb2edb1408c0b599ec89290a
Author: Steve Sakoman <steve@sakoman.com>
Date:   Tue Apr 19 08:40:52 2011 -0700

    wpa-supplicant: Enable CONFIG_CTRL_IFACE_DBUS and CONFIG_CTRL_IFACE_DBUS_NEW
    
    Signed-off-by: Steve Sakoman <steve@sakoman.com>
    Signed-off-by: Koen Kooi <koen@openembedded.org>

The comment about avoiding "cd" still applies, though.

Regards,
Andreas