Re: V3 [PATCH 0/4] Add meta-skeleton and a skeleton for init scripts

[Robert Yang <liezhi.yang@windriver.com>]

On 05/17/2011 01:34 PM, Darren Hart wrote:
> Robert,
>
> I think we're just about there. I added my final comments to the
> following patches. If you'll resubmit with those addressed, I believe we
> are ready to push.
>

Hi Darren,

Your comments is very important to me, I've learned a lot from you comments,
I'm a newbie to poky, this can make me start from a right way:-).

BTW, then indent of pidofproc () was caused by a mistake, I did "git stash"
then "git stash apply", but forgot to fix the indent.

I'll update the patches and push them, and waiting for Saul to merge them
if he is happy.

Thanks

//Robert

> Thank you for your patience, I think it is particularly important for
> our canonical example be precise in both form and function.
>
> --
> Darren
>
> On 05/16/2011 07:39 PM, Robert Yang wrote:
>> Changes of V3:
>>    * Correct the typos
>>    * Cleanup the whitespace in ${sysconfdir}/init.d/functions
>>    * Don't indent in the cases of case, e.g.:
>>      case $? in
>>      0)
>>          do_yes
>>          ;;
>>      1)
>>          do_no
>>          ;;
>>      esac
>>    * Try to remove the "<cmd>  || status=$?", I just remove one of them,
>>      fo other cases I had to save "$?" and return it at the end of the
>>      function.
>>
>>
>> Pull URL: git://git.pokylinux.org/poky-contrib.git
>>    Branch: robert/init_scripts
>>    Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=robert/init_scripts
>>
>> Thanks,
>>      Robert Yang<liezhi.yang@windriver.com>
>> ---
>>
>>
>> Robert Yang (4):
>>    Add the layer meta-skeleton
>>    Cleanup the whitespace in functions
>>    Add pidofproc to ${sysconfdir}/init.d/functions
>>    Add a skeleton for init scripts
>>
>>   meta-skeleton/conf/layer.conf                      |   10 +
>>   .../recipes-skeleton/service/service/COPYRIGHT     |   15 ++
>>   .../recipes-skeleton/service/service/skeleton      |  193 ++++++++++++++++++++
>>   .../service/service/skeleton_test.c                |   11 +
>>   .../recipes-skeleton/service/service_0.1.bb        |   32 ++++
>>   .../initscripts/initscripts-1.0/functions          |   39 ++++-
>>   6 files changed, 295 insertions(+), 5 deletions(-)
>>   create mode 100644 meta-skeleton/conf/layer.conf
>>   create mode 100644 meta-skeleton/recipes-skeleton/service/service/COPYRIGHT
>>   create mode 100644 meta-skeleton/recipes-skeleton/service/service/skeleton
>>   create mode 100644 meta-skeleton/recipes-skeleton/service/service/skeleton_test.c
>>   create mode 100644 meta-skeleton/recipes-skeleton/service/service_0.1.bb
>>
>