All of lore.kernel.org
 help / color / mirror / Atom feed
From: supriya kannery <supriyak@in.ibm.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Kevin Wolf <kwolf@redhat.com>,
	Supriya Kannery <supriyak@linux.vnet.ibm.com>,
	Prerna Saxena <prerna@linux.vnet.ibm.com>,
	Christoph Hellwig <hch@lst.de>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC Patch 0/3]Qemu: Enable dynamic cache change through qemu monitor
Date: Tue, 17 May 2011 14:57:19 +0530	[thread overview]
Message-ID: <4DD23F77.3050407@in.ibm.com> (raw)
In-Reply-To: <4DD192BD.3030200@codemonkey.ws>

Anthony Liguori wrote:
> On 05/16/2011 03:23 PM, Christoph Hellwig wrote:
>> Why are you even trying this again?  As explained very clearly last 
>> time you
>> can't change from a writeback-style to a write-through style I/O from
>> the monitor without creating massive data integrity problems.
>
> To further clarify:
>
> Today cache=none|writethrough|writeback does two things.  It:
>
> 1) Changes the WCE flag that's visible to the guest
>
> 2) Determines whether the host page cache is used for doing guest I/O
>
> As Christoph is very correct in pointing out, we cannot change (1) at 
> run time because this is guest visible.  You will break a guest if you 
> do this.
>
ok
> But it's still desirable to be able to change (2) at run time.  Before 
> we can do this properly though, we need to separate out the logic for 
> setting (1) vs. (2).
>
Will go through the code in detail to understand handling of (1) and (2).
> And ideally, we would allow (1) to be changed by the guest itself at 
> run time which allows for full dynamic control.  This is what he's 
> referring to below.
>
> Regards,
>
> Anthony Liguori
>
>   See my
>> patchset that allows changing this from the guest for how it should be
>> done - I just need to get back and revisit the virtio protocol support
>> for it.
>>
>>
>
>

  reply	other threads:[~2011-05-17  9:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-16 18:10 [Qemu-devel] [RFC Patch 0/3]Qemu: Enable dynamic cache change through qemu monitor Supriya Kannery
2011-05-16 18:10 ` [Qemu-devel] [RFC Patch 1/3]Qemu: Enhance "info block" to display cache setting Supriya Kannery
2011-05-17  8:39   ` Kevin Wolf
2011-05-17  9:00     ` supriya kannery
2011-05-16 18:10 ` [Qemu-devel] [RFC Patch 2/3]Qemu: New error classes for file reopen and device insertion Supriya Kannery
2011-05-16 18:11 ` [Qemu-devel] [RFC Patch 3/3]Qemu: Add command "cache_set" for dynamic cache change Supriya Kannery
2011-05-16 20:23 ` [Qemu-devel] [RFC Patch 0/3]Qemu: Enable dynamic cache change through qemu monitor Christoph Hellwig
2011-05-16 21:10   ` Anthony Liguori
2011-05-17  9:27     ` supriya kannery [this message]
2011-05-17 15:41     ` Christoph Hellwig
2011-05-20  5:41       ` Supriya Kannery
2011-05-17  9:18   ` supriya kannery

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DD23F77.3050407@in.ibm.com \
    --to=supriyak@in.ibm.com \
    --cc=anthony@codemonkey.ws \
    --cc=hch@lst.de \
    --cc=kwolf@redhat.com \
    --cc=prerna@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=supriyak@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.