* Re: [Patch 1/1]: cris: typo in mach-fs Makefile
[not found] <4DD145B7.6070903@uwaterloo.ca>
@ 2011-05-17 9:19 ` Jiri Kosina
0 siblings, 0 replies; 3+ messages in thread
From: Jiri Kosina @ 2011-05-17 9:19 UTC (permalink / raw)
To: Sarah Nadi; +Cc: starvik, linux-kernel
On Mon, 16 May 2011, Sarah Nadi wrote:
>
> From: Sarah Nadi <snadi@uwaterloo.ca>
>
> There is a possible typo in arch/cris/arch-v32/mach-fs/Makefile. Check diff below
There are several issues with this patch.
>
> --- Makefile 2011-05-16 11:24:21.627239213 -0400
> +++ Makefile-orig 2011-03-14 21:20:32.000000000 -0400
It can't be applied using '-p1' from a top-level kernel tree directory.
> @@ -4,7 +4,7 @@
> #
>
> obj-y := dma.o pinmux.o io.o arbiter.o
> -obj-$(CONFIG_ETRAX_VCS_SIM) += vcs_hook.o
> +bj-$(CONFIG_ETRAX_VCS_SIM) += vcs_hook.o
It's reversed.
Could you please fix that and resend?
Thanks,
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Patch 1/1]: cris: typo in mach-fs Makefile
@ 2011-05-17 14:38 Sarah Nadi
2011-05-18 11:19 ` Jiri Kosina
0 siblings, 1 reply; 3+ messages in thread
From: Sarah Nadi @ 2011-05-17 14:38 UTC (permalink / raw)
To: jkosina; +Cc: starvik, linux-kernel
From: Sarah Nadi<snadi@uwaterloo.ca>
There is a possible typo in arch/cris/arch-v32/mach-fs/Makefile. Check diff below
--- linux-2.6.38/arch/cris/arch-v32/mach-fs/Makefile.orig 2011-03-14
21:20:32.000000000 -0400
+++ linux-2.6.38/arch/cris/arch-v32/mach-fs/Makefile 2011-05-16
11:24:21.627239213 -0400
@@ -4,7 +4,7 @@
#
obj-y := dma.o pinmux.o io.o arbiter.o
-bj-$(CONFIG_ETRAX_VCS_SIM) += vcs_hook.o
+obj-$(CONFIG_ETRAX_VCS_SIM) += vcs_hook.o
obj-$(CONFIG_CPU_FREQ) += cpufreq.o
clean:
Signed-off-by: Sarah Nadi <snadi@uwaterloo.ca>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Patch 1/1]: cris: typo in mach-fs Makefile
2011-05-17 14:38 [Patch 1/1]: cris: typo in mach-fs Makefile Sarah Nadi
@ 2011-05-18 11:19 ` Jiri Kosina
0 siblings, 0 replies; 3+ messages in thread
From: Jiri Kosina @ 2011-05-18 11:19 UTC (permalink / raw)
To: Sarah Nadi; +Cc: starvik, linux-kernel, Jesper Nilsson
On Tue, 17 May 2011, Sarah Nadi wrote:
> From: Sarah Nadi<snadi@uwaterloo.ca>
>
> There is a possible typo in arch/cris/arch-v32/mach-fs/Makefile. Check diff
> below
>
> Signed-off-by: Sarah Nadi <snadi@uwaterloo.ca>
Funny that noone noticed since 2007 when this has been introduced. Makes
one wonder how much is this code really used.
Adding Jesper to CC so that he is aware of this.
I will be applying it to my tree, thanks.
>
> --- linux-2.6.38/arch/cris/arch-v32/mach-fs/Makefile.orig 2011-03-14
> 21:20:32.000000000 -0400
> +++ linux-2.6.38/arch/cris/arch-v32/mach-fs/Makefile 2011-05-16
> 11:24:21.627239213 -0400
> @@ -4,7 +4,7 @@
> #
>
> obj-y := dma.o pinmux.o io.o arbiter.o
> -bj-$(CONFIG_ETRAX_VCS_SIM) += vcs_hook.o
> +obj-$(CONFIG_ETRAX_VCS_SIM) += vcs_hook.o
> obj-$(CONFIG_CPU_FREQ) += cpufreq.o
>
> clean:
>
>
>
>
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-05-18 11:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-17 14:38 [Patch 1/1]: cris: typo in mach-fs Makefile Sarah Nadi
2011-05-18 11:19 ` Jiri Kosina
[not found] <4DD145B7.6070903@uwaterloo.ca>
2011-05-17 9:19 ` Jiri Kosina
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.