From: Richard Henderson <rth@twiddle.net>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 06/11] TCG/x86: use stack for TCG temps
Date: Tue, 17 May 2011 07:57:53 -0700 [thread overview]
Message-ID: <4DD28CF1.4030104@twiddle.net> (raw)
In-Reply-To: <BANLkTi=WFTufHML4ikeSJjU4BG=Qq7vNjQ@mail.gmail.com>
On 05/14/2011 12:38 PM, Blue Swirl wrote:
> - frame_size = push_size + TCG_STATIC_CALL_ARGS_SIZE;
> + frame_size = push_size + TCG_STATIC_CALL_ARGS_SIZE +
> + CPU_TEMP_BUF_NLONGS * sizeof(long);
> frame_size = (frame_size + TCG_TARGET_STACK_ALIGN - 1) &
> ~(TCG_TARGET_STACK_ALIGN - 1);
> stack_addend = frame_size - push_size;
> + tcg_set_frame(s, TCG_REG_ESP, 0, CPU_TEMP_BUF_NLONGS * sizeof(long));
> +
> + /* Save all callee saved registers. */
> + for (i = 0; i < ARRAY_SIZE(tcg_target_callee_save_regs); i++) {
> + tcg_out_push(s, tcg_target_callee_save_regs[i]);
> + }
> +
> tcg_out_addi(s, TCG_REG_ESP, -stack_addend);
Wrong argument to tcg_set_frame. The temps need to be above the
outgoing call arguments, i.e. offset TCG_STATIC_CALL_ARGS_SIZE.
r~
next prev parent reply other threads:[~2011-05-17 14:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-14 19:38 [Qemu-devel] [PATCH 06/11] TCG/x86: use stack for TCG temps Blue Swirl
2011-05-17 14:57 ` Richard Henderson [this message]
2011-05-17 18:46 ` Aurelien Jarno
2011-05-17 20:08 ` Blue Swirl
2011-05-18 16:09 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DD28CF1.4030104@twiddle.net \
--to=rth@twiddle.net \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.