From: jdzheng@broadcom.com (Jiandong Zheng)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: bcmring: fix patches to convert to sp804 clockevents
Date: Tue, 17 May 2011 16:42:26 -0700 [thread overview]
Message-ID: <4DD307E2.7010302@broadcom.com> (raw)
In-Reply-To: <20110517232015.GC5913@n2100.arm.linux.org.uk>
On 5/17/2011 4:20 PM, Russell King - ARM Linux wrote:
> On Tue, May 17, 2011 at 04:04:34PM -0700, Jiandong Zheng wrote:
>> @@ -232,12 +230,14 @@ void __init bcmring_init_timer(void)
>> writel(0, TIMER2_VA_BASE + TIMER_CTRL);
>> writel(0, TIMER3_VA_BASE + TIMER_CTRL);
>>
>> + clkdev_add_table(lookups, ARRAY_SIZE(lookups));
>> +
>
> As we have the init_early callback in the machine record, can this be
> done at that point, rather than sticking it in the timer init callback?
>
It should be OK as long as the table is added early enough but leave it
here make it a little easier to understand the init order.
clkdev_add_table() was called by init_machine() which is too late while
some other machines still do similar thing. Should we move
clkdev_add_table() to init_early for all SoC using sp804?
next prev parent reply other threads:[~2011-05-17 23:42 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-16 17:23 [PATCH v2 00/19] Consolidate simple ARM MMIO clock sources Russell King - ARM Linux
2011-05-16 17:23 ` Russell King - ARM Linux
2011-05-16 17:25 ` [PATCH 01/19] Make clocksource name const Russell King - ARM Linux
2011-05-16 17:25 ` Russell King - ARM Linux
2011-05-19 1:24 ` Hans J. Koch
2011-05-19 1:24 ` Hans J. Koch
2011-05-19 7:19 ` Linus Walleij
2011-05-19 7:19 ` Linus Walleij
2011-05-16 17:26 ` [PATCH 02/19] ARM: s5p: consolidate selection of timer register Russell King - ARM Linux
2011-05-16 17:26 ` [PATCH 03/19] ARM: omap1: delete useless interrupt handler Russell King - ARM Linux
2011-05-16 17:26 ` Russell King - ARM Linux
2011-05-16 17:26 ` [PATCH 04/19] ARM: omap1: convert to using readl/writel instead of volatile struct Russell King - ARM Linux
2011-05-16 17:26 ` Russell King - ARM Linux
2011-05-17 21:59 ` Catalin Marinas
2011-05-17 21:59 ` Catalin Marinas
2011-05-18 7:56 ` Russell King - ARM Linux
2011-05-18 7:56 ` Russell King - ARM Linux
2011-05-18 20:48 ` Linus Walleij
2011-05-18 20:48 ` Linus Walleij
2011-05-16 17:27 ` [PATCH 05/19] ARM: update sa1100 to reflect PXA updates Russell King - ARM Linux
2011-05-16 17:27 ` [PATCH 06/19] clocksource: add common mmio clocksource Russell King - ARM Linux
2011-05-16 17:27 ` Russell King - ARM Linux
2011-05-16 17:27 ` [PATCH 07/19] clocksource: convert ARM 32-bit up counting clocksources Russell King - ARM Linux
2011-05-16 18:30 ` Eric Miao
2011-05-17 6:38 ` Sascha Hauer
2011-05-16 17:28 ` [PATCH 08/19] clocksource: convert ARM 32-bit down " Russell King - ARM Linux
2011-05-16 17:28 ` [PATCH 09/19] clocksource: convert W90x900 24-bit down counting clocksource Russell King - ARM Linux
2011-05-16 17:28 ` [PATCH 10/19] clocksource: convert Integrator/AP 16-bit " Russell King - ARM Linux
2011-05-16 17:29 ` [PATCH 11/19] clocksource: convert SPEAr platforms 16-bit up " Russell King - ARM Linux
2011-05-16 17:29 ` [PATCH 12/19] clocksource: convert MXS timrotv2 to 32-bit down " Russell King - ARM Linux
2011-05-16 17:29 ` [PATCH 13/19] clocksource: convert OMAP1 " Russell King - ARM Linux
2011-05-16 17:29 ` Russell King - ARM Linux
2011-05-16 17:30 ` [PATCH 14/19] clocksource: ARM sp804: allow clocksource name to be specified Russell King - ARM Linux
2011-05-16 17:30 ` [PATCH 15/19] clocksource: ARM sp804: obtain sp804 timer rate via clks Russell King - ARM Linux
2011-05-16 22:18 ` Rob Herring
2011-05-16 22:34 ` Russell King - ARM Linux
2011-05-16 17:30 ` [PATCH 16/19] clockevents: ARM sp804: allow clockevent name to be specified Russell King - ARM Linux
2011-05-16 21:25 ` Rob Herring
2011-05-16 21:33 ` Russell King - ARM Linux
2011-05-23 10:55 ` Catalin Marinas
2011-05-16 17:31 ` [PATCH 17/19] clockevents: ARM sp804: obtain sp804 timer rate via clks Russell King - ARM Linux
2011-05-16 21:24 ` Rob Herring
2011-05-16 21:34 ` Russell King - ARM Linux
2011-05-23 10:56 ` Catalin Marinas
2011-05-16 17:31 ` [PATCH 18/19] ARM: bcmring: convert to sp804 clocksource Russell King - ARM Linux
2011-05-16 17:31 ` [PATCH 19/19] ARM: bcmring: convert to use sp804 clockevents Russell King - ARM Linux
2011-05-17 23:04 ` [PATCH] ARM: bcmring: fix patches to convert to " Jiandong Zheng
2011-05-17 23:20 ` Russell King - ARM Linux
2011-05-17 23:42 ` Jiandong Zheng [this message]
2011-05-18 15:46 ` Russell King - ARM Linux
2011-05-18 18:01 ` [PATCH] ARM: bcmring: Add clkdev table in init_early Jiandong Zheng
2011-05-18 20:42 ` Russell King - ARM Linux
2011-05-18 22:37 ` Russell King - ARM Linux
2011-05-18 22:45 ` Jiandong Zheng
2011-05-18 22:52 ` Russell King - ARM Linux
2011-05-18 23:38 ` Jiandong Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DD307E2.7010302@broadcom.com \
--to=jdzheng@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.