From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liam Girdwood Subject: Re: [PATCH] Max98095: Move existing NULL check before pointer dereference. Date: Wed, 18 May 2011 10:32:39 +0100 Message-ID: <4DD39237.5040905@ti.com> References: <1305680634-10484-1-git-send-email-thutt@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from bear.ext.ti.com (bear.ext.ti.com [192.94.94.41]) by alsa0.perex.cz (Postfix) with ESMTP id CC1E110383E for ; Wed, 18 May 2011 11:32:42 +0200 (CEST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Peter Hsiang Cc: "alsa-devel@alsa-project.org" , Takashi Iwai , Mark Brown , "linux-kernel@vger.kernel.org" , Taylor Hutt , Liam Girdwood List-Id: alsa-devel@alsa-project.org On 18/05/11 02:28, Peter Hsiang wrote: > On Tue, May 17, 2011, Taylor Hutt wrote: > >> Visual inspection shows that max98095_put_eq_enum() and >> max98095_put_bq_enum() each have a possible NULL deref of 'pdata'. >> >> This change moves the NULL check above the use. >> >> BUG=none >> TEST=Visual inspection > > Mark, this patch looks good. > Thank you Taylor. > Acked-by: Liam Girdwood From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932616Ab1ERJc4 (ORCPT ); Wed, 18 May 2011 05:32:56 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:46854 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932138Ab1ERJcz (ORCPT ); Wed, 18 May 2011 05:32:55 -0400 Message-ID: <4DD39237.5040905@ti.com> Date: Wed, 18 May 2011 10:32:39 +0100 From: Liam Girdwood User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110424 Lightning/1.0b2 Thunderbird/3.1.10 MIME-Version: 1.0 To: Peter Hsiang CC: Taylor Hutt , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" Subject: Re: [alsa-devel] [PATCH] Max98095: Move existing NULL check before pointer dereference. References: <1305680634-10484-1-git-send-email-thutt@chromium.org> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/05/11 02:28, Peter Hsiang wrote: > On Tue, May 17, 2011, Taylor Hutt wrote: > >> Visual inspection shows that max98095_put_eq_enum() and >> max98095_put_bq_enum() each have a possible NULL deref of 'pdata'. >> >> This change moves the NULL check above the use. >> >> BUG=none >> TEST=Visual inspection > > Mark, this patch looks good. > Thank you Taylor. > Acked-by: Liam Girdwood