Re: [PATCH] bcma: pci: implement enabling interrupts

["Arend van Spriel" <arend@broadcom.com>]

On 05/18/2011 01:26 PM, Rafał Miłecki wrote:
> W dniu 18 maja 2011 12:39 użytkownik Arend van Spriel
> <arend@broadcom.com>  napisał:
>> On 05/18/2011 12:58 PM, Rafał Miłecki wrote:
>>> Signed-off-by: Rafał Miłecki<zajec5@gmail.com>
>>> ---
>>>   drivers/bcma/driver_pci.c |   18 ++++++++++++++++++
>>>   1 files changed, 18 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/drivers/bcma/driver_pci.c b/drivers/bcma/driver_pci.c
>>> index e757e4e..879fe1d 100644
>>> --- a/drivers/bcma/driver_pci.c
>>> +++ b/drivers/bcma/driver_pci.c
>>> @@ -161,3 +161,21 @@ void bcma_core_pci_init(struct bcma_drv_pci *pc)
>>>   {
>>>         bcma_pcicore_serdes_workaround(pc);
>>>   }
>>> +
>>> +int bcma_core_pci_irq_enable(struct bcma_drv_pci *pc, struct bcma_device
>>> *core)
>>> +{
>>> +       struct pci_dev *pdev = pc->core->bus->host_pci;
>>> +       u32 coremask, tmp;
>>> +       int err;
>>> +
>>> +       coremask = BIT(core->core_index);
>>> +
>>> +       err = pci_read_config_dword(pdev, BCMA_PCI_IRQMASK,&tmp);
>>> +       if (err)
>>> +               goto out;
>>> +       tmp |= coremask<<    8;
>>> +       err = pci_write_config_dword(pdev, BCMA_PCI_IRQMASK, tmp);
>>> +
>>> +out:
>>> +       return err;
>>> +}
>> Hi Rafał,
>>
>> Do you intend to have a disable as well?
> Sure. I just didn't test disabling function yet, that's why I didn't publish it.

Thanks,

I was just wondering whether there would be a yang for this yin ;-)

Gr. AvS

-- 
Almost nobody dances sober, unless they happen to be insane.
-- H.P. Lovecraft --