* [PATCHv4 4/6] GPIO: TPS65910: Move driver to drivers/gpio/
@ 2011-05-16 23:35 Jorge Eduardo Candelaria
2011-05-18 16:42 ` Liam Girdwood
0 siblings, 1 reply; 3+ messages in thread
From: Jorge Eduardo Candelaria @ 2011-05-16 23:35 UTC (permalink / raw)
To: linux-kernel; +Cc: broonie, sameo, Liam Girdwood, Graeme Gregory, grant.likely
The GPIO driver should reside in drivers/gpio/ for better
organization.
Signed-off-by: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
---
drivers/gpio/Kconfig | 7 +++
drivers/gpio/Makefile | 1 +
drivers/gpio/tps65910-gpio.c | 91 ++++++++++++++++++++++++++++++++++++++++++
drivers/mfd/Kconfig | 3 +-
drivers/mfd/Makefile | 2 +-
drivers/mfd/tps65910-gpio.c | 91 ------------------------------------------
6 files changed, 102 insertions(+), 93 deletions(-)
create mode 100644 drivers/gpio/tps65910-gpio.c
delete mode 100644 drivers/mfd/tps65910-gpio.c
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index d3b2953..3a49cc5 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -419,4 +419,11 @@ config AB8500_GPIO
depends on AB8500_CORE && BROKEN
help
Select this to enable the AB8500 IC GPIO driver
+
+config GPIO_TPS65910
+ bool "TPS65910 GPIO"
+ depends on MFD_TPS65910
+ help
+ Select this option to enable GPIO driver for the TPS65910
+ chip family.
endif
diff --git a/drivers/gpio/Makefile b/drivers/gpio/Makefile
index becef59..8d7eac0 100644
--- a/drivers/gpio/Makefile
+++ b/drivers/gpio/Makefile
@@ -43,3 +43,4 @@ obj-$(CONFIG_GPIO_SX150X) += sx150x.o
obj-$(CONFIG_GPIO_VX855) += vx855_gpio.o
obj-$(CONFIG_GPIO_ML_IOH) += ml_ioh_gpio.o
obj-$(CONFIG_AB8500_GPIO) += ab8500-gpio.o
+obj-$(CONFIG_GPIO_TPS65910) += tps65910-gpio.o
diff --git a/drivers/gpio/tps65910-gpio.c b/drivers/gpio/tps65910-gpio.c
new file mode 100644
index 0000000..f3ae376
--- /dev/null
+++ b/drivers/gpio/tps65910-gpio.c
@@ -0,0 +1,91 @@
+/*
+ * tps65910-gpio.c -- TI TPS6591x
+ *
+ * Copyright 2010 Texas Instruments Inc.
+ *
+ * Author: Graeme Gregory <gg@slimlogic.co.uk>
+ * Author: Jorge Eduardo Candelaria jedu@slimlogic.co.uk>
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License as published by the
+ * Free Software Foundation; either version 2 of the License, or (at your
+ * option) any later version.
+ *
+ */
+
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/errno.h>
+#include <linux/gpio.h>
+#include <linux/i2c.h>
+#include <linux/mfd/tps65910.h>
+
+static int tps65910_gpio_get(struct gpio_chip *gc, unsigned offset)
+{
+ struct tps65910 *tps65910 = container_of(gc, struct tps65910, gpio);
+ uint8_t val;
+
+ tps65910->read(tps65910, TPS65910_GPIO0, 1, &val);
+
+ if (val & GPIO0_GPIO_STS_MASK)
+ return 1;
+
+ return 0;
+}
+
+static void tps65910_gpio_set(struct gpio_chip *gc, unsigned offset,
+ int value)
+{
+ struct tps65910 *tps65910 = container_of(gc, struct tps65910, gpio);
+
+ if (value)
+ tps65910_set_bits(tps65910, TPS65910_GPIO0,
+ GPIO0_GPIO_SET_MASK);
+ else
+ tps65910_clear_bits(tps65910, TPS65910_GPIO0,
+ GPIO0_GPIO_SET_MASK);
+}
+
+static int tps65910_gpio_output(struct gpio_chip *gc, unsigned offset,
+ int value)
+{
+ struct tps65910 *tps65910 = container_of(gc, struct tps65910, gpio);
+
+ /* Set the initial value */
+ tps65910_gpio_set(gc, 0, value);
+
+ return tps65910_set_bits(tps65910, TPS65910_GPIO0, GPIO0_GPIO_CFG_MASK);
+}
+
+static int tps65910_gpio_input(struct gpio_chip *gc, unsigned offset)
+{
+ struct tps65910 *tps65910 = container_of(gc, struct tps65910, gpio);
+
+ return tps65910_clear_bits(tps65910, TPS65910_GPIO0,
+ GPIO0_GPIO_CFG_MASK);
+}
+
+void tps65910_gpio_init(struct tps65910 *tps65910, int gpio_base)
+{
+ int ret;
+
+ if (!gpio_base)
+ return;
+
+ tps65910->gpio.owner = THIS_MODULE;
+ tps65910->gpio.label = tps65910->i2c_client->name;
+ tps65910->gpio.dev = tps65910->dev;
+ tps65910->gpio.base = gpio_base;
+ tps65910->gpio.ngpio = 1;
+ tps65910->gpio.can_sleep = 1;
+
+ tps65910->gpio.direction_input = tps65910_gpio_input;
+ tps65910->gpio.direction_output = tps65910_gpio_output;
+ tps65910->gpio.set = tps65910_gpio_set;
+ tps65910->gpio.get = tps65910_gpio_get;
+
+ ret = gpiochip_add(&tps65910->gpio);
+
+ if (ret)
+ dev_warn(tps65910->dev, "GPIO registration failed: %d\n", ret);
+}
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 0131d49..3f4bb6e 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -673,8 +673,9 @@ config MFD_OMAP_USB_HOST
config MFD_TPS65910
bool "TPS65910 Power Management chip"
- depends on I2C=y && GPIOLIB
+ depends on I2C=y
select MFD_CORE
+ select GPIO_TPS65910
help
if you say yes here you get support for the TPS65910 series of
Power Management chips.
diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
index c771eed..e905d30 100644
--- a/drivers/mfd/Makefile
+++ b/drivers/mfd/Makefile
@@ -88,4 +88,4 @@ obj-$(CONFIG_MFD_VX855) += vx855.o
obj-$(CONFIG_MFD_WL1273_CORE) += wl1273-core.o
obj-$(CONFIG_MFD_CS5535) += cs5535-mfd.o
obj-$(CONFIG_MFD_OMAP_USB_HOST) += omap-usb-host.o
-obj-$(CONFIG_MFD_TPS65910) += tps65910.o tps65910-gpio.o tps65910-irq.o
+obj-$(CONFIG_MFD_TPS65910) += tps65910.o tps65910-irq.o
diff --git a/drivers/mfd/tps65910-gpio.c b/drivers/mfd/tps65910-gpio.c
deleted file mode 100644
index f3ae376..0000000
--- a/drivers/mfd/tps65910-gpio.c
+++ /dev/null
@@ -1,91 +0,0 @@
-/*
- * tps65910-gpio.c -- TI TPS6591x
- *
- * Copyright 2010 Texas Instruments Inc.
- *
- * Author: Graeme Gregory <gg@slimlogic.co.uk>
- * Author: Jorge Eduardo Candelaria jedu@slimlogic.co.uk>
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License as published by the
- * Free Software Foundation; either version 2 of the License, or (at your
- * option) any later version.
- *
- */
-
-#include <linux/kernel.h>
-#include <linux/module.h>
-#include <linux/errno.h>
-#include <linux/gpio.h>
-#include <linux/i2c.h>
-#include <linux/mfd/tps65910.h>
-
-static int tps65910_gpio_get(struct gpio_chip *gc, unsigned offset)
-{
- struct tps65910 *tps65910 = container_of(gc, struct tps65910, gpio);
- uint8_t val;
-
- tps65910->read(tps65910, TPS65910_GPIO0, 1, &val);
-
- if (val & GPIO0_GPIO_STS_MASK)
- return 1;
-
- return 0;
-}
-
-static void tps65910_gpio_set(struct gpio_chip *gc, unsigned offset,
- int value)
-{
- struct tps65910 *tps65910 = container_of(gc, struct tps65910, gpio);
-
- if (value)
- tps65910_set_bits(tps65910, TPS65910_GPIO0,
- GPIO0_GPIO_SET_MASK);
- else
- tps65910_clear_bits(tps65910, TPS65910_GPIO0,
- GPIO0_GPIO_SET_MASK);
-}
-
-static int tps65910_gpio_output(struct gpio_chip *gc, unsigned offset,
- int value)
-{
- struct tps65910 *tps65910 = container_of(gc, struct tps65910, gpio);
-
- /* Set the initial value */
- tps65910_gpio_set(gc, 0, value);
-
- return tps65910_set_bits(tps65910, TPS65910_GPIO0, GPIO0_GPIO_CFG_MASK);
-}
-
-static int tps65910_gpio_input(struct gpio_chip *gc, unsigned offset)
-{
- struct tps65910 *tps65910 = container_of(gc, struct tps65910, gpio);
-
- return tps65910_clear_bits(tps65910, TPS65910_GPIO0,
- GPIO0_GPIO_CFG_MASK);
-}
-
-void tps65910_gpio_init(struct tps65910 *tps65910, int gpio_base)
-{
- int ret;
-
- if (!gpio_base)
- return;
-
- tps65910->gpio.owner = THIS_MODULE;
- tps65910->gpio.label = tps65910->i2c_client->name;
- tps65910->gpio.dev = tps65910->dev;
- tps65910->gpio.base = gpio_base;
- tps65910->gpio.ngpio = 1;
- tps65910->gpio.can_sleep = 1;
-
- tps65910->gpio.direction_input = tps65910_gpio_input;
- tps65910->gpio.direction_output = tps65910_gpio_output;
- tps65910->gpio.set = tps65910_gpio_set;
- tps65910->gpio.get = tps65910_gpio_get;
-
- ret = gpiochip_add(&tps65910->gpio);
-
- if (ret)
- dev_warn(tps65910->dev, "GPIO registration failed: %d\n", ret);
-}
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCHv4 4/6] GPIO: TPS65910: Move driver to drivers/gpio/
2011-05-16 23:35 [PATCHv4 4/6] GPIO: TPS65910: Move driver to drivers/gpio/ Jorge Eduardo Candelaria
@ 2011-05-18 16:42 ` Liam Girdwood
2011-05-18 17:50 ` Grant Likely
0 siblings, 1 reply; 3+ messages in thread
From: Liam Girdwood @ 2011-05-18 16:42 UTC (permalink / raw)
To: grant.likely@secretlab.ca
Cc: Jorge Eduardo Candelaria, linux-kernel@vger.kernel.org,
broonie@opensource.wolfsonmicro.com, sameo@linux.intel.com,
Graeme Gregory
On 17/05/11 00:35, Jorge Eduardo Candelaria wrote:
> The GPIO driver should reside in drivers/gpio/ for better
> organization.
>
> Signed-off-by: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
> ---
> drivers/gpio/Kconfig | 7 +++
> drivers/gpio/Makefile | 1 +
> drivers/gpio/tps65910-gpio.c | 91 ++++++++++++++++++++++++++++++++++++++++++
> drivers/mfd/Kconfig | 3 +-
> drivers/mfd/Makefile | 2 +-
> drivers/mfd/tps65910-gpio.c | 91 ------------------------------------------
> 6 files changed, 102 insertions(+), 93 deletions(-)
> create mode 100644 drivers/gpio/tps65910-gpio.c
> delete mode 100644 drivers/mfd/tps65910-gpio.c
>
Grant, if you are happy with this I can this series altogether via regulator.
Thanks
Liam
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCHv4 4/6] GPIO: TPS65910: Move driver to drivers/gpio/
2011-05-18 16:42 ` Liam Girdwood
@ 2011-05-18 17:50 ` Grant Likely
0 siblings, 0 replies; 3+ messages in thread
From: Grant Likely @ 2011-05-18 17:50 UTC (permalink / raw)
To: Liam Girdwood
Cc: Jorge Eduardo Candelaria, linux-kernel@vger.kernel.org,
broonie@opensource.wolfsonmicro.com, sameo@linux.intel.com,
Graeme Gregory
On Wed, May 18, 2011 at 05:42:31PM +0100, Liam Girdwood wrote:
> On 17/05/11 00:35, Jorge Eduardo Candelaria wrote:
> > The GPIO driver should reside in drivers/gpio/ for better
> > organization.
> >
> > Signed-off-by: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
> > ---
> > drivers/gpio/Kconfig | 7 +++
> > drivers/gpio/Makefile | 1 +
> > drivers/gpio/tps65910-gpio.c | 91 ++++++++++++++++++++++++++++++++++++++++++
> > drivers/mfd/Kconfig | 3 +-
> > drivers/mfd/Makefile | 2 +-
> > drivers/mfd/tps65910-gpio.c | 91 ------------------------------------------
> > 6 files changed, 102 insertions(+), 93 deletions(-)
> > create mode 100644 drivers/gpio/tps65910-gpio.c
> > delete mode 100644 drivers/mfd/tps65910-gpio.c
> >
>
> Grant, if you are happy with this I can this series altogether via regulator.
Yes, go ahead and take the series all together.
g.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-05-18 17:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-16 23:35 [PATCHv4 4/6] GPIO: TPS65910: Move driver to drivers/gpio/ Jorge Eduardo Candelaria
2011-05-18 16:42 ` Liam Girdwood
2011-05-18 17:50 ` Grant Likely
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.