From: Damian Hobson-Garcia <dhobsong@igel.co.jp>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 4/6 v2] sh_mobile_meram: MERAM platform data for LCDC
Date: Thu, 19 May 2011 01:18:02 +0000 [thread overview]
Message-ID: <4DD46FCA.50906@igel.co.jp> (raw)
In-Reply-To: <1305717011-20742-5-git-send-email-dhobsong@igel.co.jp>
On 2011/05/19 9:42, Magnus Damm wrote:
> Hi Damian,
>
> On Wed, May 18, 2011 at 8:10 PM, Damian Hobson-Garcia
> <dhobsong@igel.co.jp> wrote:
>> Based on the patch by Takanari Hayama <taki@igel.co.jp>
>>
>> Add the necessary platform data to add MERAM functionality to LCDC
>>
>> Includes platform data for both the AP4EVB and mackerel
>>
>> Signed-off-by: Damian Hobson-Garcia <dhobsong@igel.co.jp>
>> ---
>> Changed from V1
>> ==>> * Changed .id from -1 to 0 in platform data
>> * Added mackerel platform data
>
> Thanks for your work on this!
>
>> arch/arm/mach-shmobile/board-ap4evb.c | 73 ++++++++++++++++++++++++++++++
>> arch/arm/mach-shmobile/board-mackerel.c | 74 +++++++++++++++++++++++++++++++
>> 2 files changed, 147 insertions(+), 0 deletions(-)
>>
>> +#ifdef CONFIG_FB_SH_MOBILE_MERAM
>> +#endif
>> +#ifdef CONFIG_FB_SH_MOBILE_MERAM
>> +#endif
>> +#ifdef CONFIG_FB_SH_MOBILE_MERAM
>> +#endif
>> +#ifdef CONFIG_FB_SH_MOBILE_MERAM
>> +#endif
>> +#ifdef CONFIG_FB_SH_MOBILE_MERAM
>> +#endif
>> +#ifdef CONFIG_FB_SH_MOBILE_MERAM
>> +#endif
>> +#ifdef CONFIG_FB_SH_MOBILE_MERAM
>> +#endif
>> +#ifdef CONFIG_FB_SH_MOBILE_MERAM
>> +#endif
>> +#ifdef CONFIG_FB_SH_MOBILE_MERAM
>> +#endif
>> +#ifdef CONFIG_FB_SH_MOBILE_MERAM
>> +#endif
>> +#ifdef CONFIG_FB_SH_MOBILE_MERAM
>> +#endif
>> +#ifdef CONFIG_FB_SH_MOBILE_MERAM
>> +#endif
>> +#ifdef CONFIG_FB_SH_MOBILE_MERAM
>> +#endif
>> +#ifdef CONFIG_FB_SH_MOBILE_MERAM
>> +#endif
>> +#ifdef CONFIG_FB_SH_MOBILE_MERAM
>> +#endif
>> +#ifdef CONFIG_FB_SH_MOBILE_MERAM
>> +#endif
>
> Uhm, hate to interfer with your #ifdef party, but... =)
>
> Could you please update the code to always define the platform data
> regardless of if CONFIG_FB_SH_MOBILE_MERAM is selected or not. That's
> the way we do it for almost all platform devices today.
Ok that's not a problem. I can rework that.
>
> The exception is for some SDHI/MMC devices that can be driven from one
> out of multiple drivers. In such case we configure the pinmux /
> platform data depending on which drivers that are available.
>
> Thanks,
>
> / magnus
--
Damian Hobson-Garcia
IGEL Co.,Ltd
http://www.igel.co.jp
prev parent reply other threads:[~2011-05-19 1:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-18 11:10 [PATCH 4/6 v2] sh_mobile_meram: MERAM platform data for LCDC Damian Hobson-Garcia
2011-05-19 0:42 ` Magnus Damm
2011-05-19 1:18 ` Damian Hobson-Garcia [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DD46FCA.50906@igel.co.jp \
--to=dhobsong@igel.co.jp \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.