From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:35809)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1QN477-0004Y9-D7
	for qemu-devel@nongnu.org; Thu, 19 May 2011 10:22:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1QN474-0007Ad-Il
	for qemu-devel@nongnu.org; Thu, 19 May 2011 10:22:09 -0400
Received: from cantor2.suse.de ([195.135.220.15]:45351 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1QN474-000783-8j
	for qemu-devel@nongnu.org; Thu, 19 May 2011 10:22:06 -0400
Message-ID: <4DD5278C.6060404@suse.de>
Date: Thu, 19 May 2011 16:22:04 +0200
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
References: <1305740441-17485-1-git-send-email-weil@mail.berlios.de>
	<alpine.DEB.2.00.1105181904120.12963@kaball-desktop>
In-Reply-To: <alpine.DEB.2.00.1105181904120.12963@kaball-desktop>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] xen: Use conditional compilation for xen
 map cache (fixes w32 builds)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Anthony Perard <anthony.perard@citrix.com>, QEMU Developers <qemu-devel@nongnu.org>

On 05/18/2011 08:27 PM, Stefano Stabellini wrote:
> On Wed, 18 May 2011, Stefan Weil wrote:
>> The current implementation used stubs for systems without XEN.
>> This is unusual for QEMU and adds unneeded dependencies.
>>
>> MinGW32 for example does not provide munmap(), so the XEN
>> code creates compiler warnings (missing prototype).
>> Compilations without optimisation even result in linker
>> errors (missing function).
>>
>> Fix this by using conditional compilation.
> After a conversation on IRC with Stefan I found out that most of the
> problems are gone away after my recent "xen mapcache fixes and
> improvements" patch series.
>
> To completely solve the compilation issues with MinGW32 I just need to
> remove two includes from xen-mapcache.h, so I am appending an updated
> version of patch #3 "xen: remove xen_map_block and xen_unmap_block" to
> do just that.
>
> I have also pushed another git branch:
>
> git://xenbits.xen.org/people/sstabellini/qemu-dm.git mapcache_fixes_2

So please resend v2 to the ML. From my POV the patches look ok, but I'd 
like to give others some more chance of commenting on them.


Alex