From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============2639733795018142223==" MIME-Version: 1.0 From: Denis Kenzior Subject: Re: [PATCH] emulator: fix dun_ath_cb() not to remove GAtServer io_disconnect() CB Date: Thu, 19 May 2011 11:11:33 -0500 Message-ID: <4DD54135.7070709@gmail.com> In-Reply-To: <1305810194-24360-1-git-send-email-guillaume.zajac@linux.intel.com> List-Id: To: ofono@ofono.org --===============2639733795018142223== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Guillaume, On 05/19/2011 08:03 AM, Guillaume Zajac wrote: > --- > src/emulator.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > = > diff --git a/src/emulator.c b/src/emulator.c > index c17b901..251bed8 100644 > --- a/src/emulator.c > +++ b/src/emulator.c > @@ -219,15 +219,19 @@ static void dun_ath_cb(GAtServer *server, GAtServer= RequestType type, > if (val !=3D 0) > goto error; > = > + g_at_server_suspend(em->server); > g_at_ppp_unref(em->ppp); > em->ppp =3D NULL; > + g_at_server_resume(em->server); > = > g_at_server_send_final(server, G_AT_SERVER_RESULT_OK); > break; > = > case G_AT_SERVER_REQUEST_TYPE_COMMAND_ONLY: > + g_at_server_suspend(em->server); > g_at_ppp_unref(em->ppp); > em->ppp =3D NULL; > + g_at_server_resume(em->server); > = > g_at_server_send_final(server, G_AT_SERVER_RESULT_OK); > break; This really sounds wrong. I suggest that we not set the disconnect function in GAtPPP when unrefing if GAtPPP is currently suspended. Regards, -Denis --===============2639733795018142223==--