From: Cyrill Gorcunov <gorcunov@gmail.com>
To: David Ahern <dsahern@gmail.com>
Cc: Sasha Levin <levinsasha928@gmail.com>,
penberg@kernel.org, mingo@elte.hu, asias.hejun@gmail.com,
prasadjoshi124@gmail.com, kvm@vger.kernel.org
Subject: Re: [PATCH] kvm tools: Default guest cpu count to host cpu count
Date: Fri, 20 May 2011 00:00:25 +0400 [thread overview]
Message-ID: <4DD576D9.4010000@gmail.com> (raw)
In-Reply-To: <4DD56AC2.9050702@gmail.com>
On 05/19/2011 11:08 PM, Cyrill Gorcunov wrote:
...
>>
>> What prevents nr_online_cpus from being greater than KVM_NR_CPUS? Since
>> that latter is a #define, might want to change 'else if' to if there.
>>
>> David
>>
>
> Good catch! We should add a constraint here and limit it to KVM_NR_CPUS.
>
Heh, actually it get catched futher in code by
max_cpus = kvm__max_cpus(kvm);
if (nrcpus > max_cpus) {
printf(" # Limit the number of CPUs to %d\n", max_cpus);
kvm->nrcpus = max_cpus;
}
so no issue here (except that MP table can support a limited number of
cpus and for 32bit apic addressing we need ACPI support implemented I think).
--
Cyrill
prev parent reply other threads:[~2011-05-19 20:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-18 19:56 [PATCH] kvm tools: Default guest cpu count to host cpu count Sasha Levin
2011-05-18 19:59 ` Cyrill Gorcunov
2011-05-19 10:35 ` Asias He
2011-05-19 19:04 ` David Ahern
2011-05-19 19:08 ` Cyrill Gorcunov
2011-05-19 20:00 ` Cyrill Gorcunov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DD576D9.4010000@gmail.com \
--to=gorcunov@gmail.com \
--cc=asias.hejun@gmail.com \
--cc=dsahern@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=mingo@elte.hu \
--cc=penberg@kernel.org \
--cc=prasadjoshi124@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.