From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] davinci: create new common platform header for davinci
Date: Fri, 20 May 2011 19:18:35 +0400 [thread overview]
Message-ID: <4DD6864B.6040305@mvista.com> (raw)
In-Reply-To: <1305900841-4020-1-git-send-email-manjunath.hadli@ti.com>
Hello.
Manjunath Hadli wrote:
> remove the code from individual platform header files for
> dm365, dm355, dm644x and dm646x and consolidate it into a
> single and common header file dmx.h.
Could we call it davinci.h instead?
> Include the new header file in individual platform header
> files as a pre-cursor for deleting these headers in follow
> up patches.
> Signed-off-by: Manjunath Hadli <manjunath.hadli@ti.com>
[...]
> diff --git a/arch/arm/mach-davinci/board-dm365-evm.c b/arch/arm/mach-davinci/board-dm365-evm.c
> index c67f684..7be75b2 100644
> --- a/arch/arm/mach-davinci/board-dm365-evm.c
> +++ b/arch/arm/mach-davinci/board-dm365-evm.c
[...]
> @@ -143,6 +143,10 @@ static struct davinci_nand_pdata davinci_nand_data = {
> .ecc_bits = 4,
> };
>
> +#define DM365_ASYNC_EMIF_CONTROL_BASE 0x01D10000
> +#define DM365_ASYNC_EMIF_DATA_CE0_BASE 0x02000000
> +#define DM365_ASYNC_EMIF_DATA_CE1_BASE 0x04000000
No, we don't want to duplicate those in every future DM365 board file. Leave
them in the header please.
> diff --git a/arch/arm/mach-davinci/board-dm646x-evm.c b/arch/arm/mach-davinci/board-dm646x-evm.c
> index f6ac9ba..73497a6 100644
> --- a/arch/arm/mach-davinci/board-dm646x-evm.c
> +++ b/arch/arm/mach-davinci/board-dm646x-evm.c
> @@ -91,6 +91,9 @@ static struct davinci_nand_pdata davinci_nand_data = {
> .options = 0,
> };
>
> +#define DM646X_ASYNC_EMIF_CONTROL_BASE 0x20008000
> +#define DM646X_ASYNC_EMIF_CS2_SPACE_BASE 0x42000000
> +
No, we don't want to duplicate those in every future DM646x board file.
Leave them in the header please.
> diff --git a/drivers/media/video/davinci/vpif_capture.h b/drivers/media/video/davinci/vpif_capture.h
> index fa50b6b..cafa762 100644
> --- a/drivers/media/video/davinci/vpif_capture.h
> +++ b/drivers/media/video/davinci/vpif_capture.h
> @@ -28,6 +28,7 @@
> #include <media/v4l2-device.h>
> #include <media/videobuf-core.h>
> #include <media/videobuf-dma-contig.h>
> +#include <mach/dmx.h>
Why, if it didn't #include any of the deleted headers before?
WBR, Sergei
next prev parent reply other threads:[~2011-05-20 15:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-20 14:14 [PATCH 4/4] davinci: create new common platform header for davinci Manjunath Hadli
2011-05-20 15:18 ` Sergei Shtylyov [this message]
2011-05-20 15:35 ` Sergei Shtylyov
2011-05-20 17:27 ` Arnd Bergmann
2011-05-20 18:14 ` Nori, Sekhar
2011-05-20 19:46 ` Arnd Bergmann
2011-05-23 8:15 ` Nori, Sekhar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DD6864B.6040305@mvista.com \
--to=sshtylyov@mvista.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.